bisect--helper: convert vocab_* char pointers to char arrays

mirucam · gitster · commit 16538bfd2c42 · 2020-02-19T09:37:14.000-08:00
Instead of using a pointer that points at a constant string,
just give name directly to the constant string; this way, we
do not have to allocate a pointer variable in addition to
the string we want to use.

Let's convert `vocab_bad` and `vocab_good` char pointers to char arrays.

Mentored-by: Christian Couder &lt;chriscool@tuxfamily.org&gt;
Signed-off-by: Miriam Rubio &lt;mirucam@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
@@ -52,8 +52,8 @@ static void set_terms(struct bisect_terms *terms, const char *bad,
 	terms->term_bad = xstrdup(bad);
 }
 
-static const char *vocab_bad = "bad|new";
-static const char *vocab_good = "good|old";
+static const char vocab_bad[] = "bad|new";
+static const char vocab_good[] = "good|old";
 
 /*
  * Check whether the string `term` belongs to the set of strings

Original file line number	Diff line number	Diff line change
`@@ -52,8 +52,8 @@ static void set_terms(struct bisect_terms terms, const char bad,`
`52`	`52`	`terms->term_bad = xstrdup(bad);`
`53`	`53`	`}`
`54`	`54`
`55`		`-static const char *vocab_bad = "bad\|new";`
`56`		`-static const char *vocab_good = "good\|old";`
	`55`	`+static const char vocab_bad[] = "bad\|new";`
	`56`	`+static const char vocab_good[] = "good\|old";`
`57`	`57`
`58`	`58`	`/*`
`59`	`59`	* Check whether the string `term` belongs to the set of strings