Skip to content

Commit 1462b67

Browse files
committed
Merge tag 'post183-for-junio' of http://github.com/msysgit/git
Collected msysgit build patches for upstream This set of patches collects a number of build fixes that have been used on the msysgit port for a while and merging upstream should simplify future maintenance. * tag 'post183-for-junio' of http://github.com/msysgit/git: Set the default help format to html for msys builds. Ensure the resource file is rebuilt when the version changes. Windows resource: handle dashes in the Git version gracefully Provide a Windows version resource for the git executables. msysgit: Add the --large-address-aware linker directive to the makefile. Define NO_GETTEXT for Git for Windows Makefile: Do not use OLD_ICONV on MINGW anymore
2 parents 882e78c + 65db044 commit 1462b67

File tree

4 files changed

+35
-2
lines changed

4 files changed

+35
-2
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,7 @@
229229
/cscope*
230230
*.obj
231231
*.lib
232+
*.res
232233
*.sln
233234
*.suo
234235
*.ncb

Makefile

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1535,6 +1535,7 @@ ifndef V
15351535
QUIET_MSGFMT = @echo ' ' MSGFMT $@;
15361536
QUIET_GCOV = @echo ' ' GCOV $@;
15371537
QUIET_SP = @echo ' ' SP $<;
1538+
QUIET_RC = @echo ' ' RC $@;
15381539
QUIET_SUBDIR0 = +@subdir=
15391540
QUIET_SUBDIR1 = ;$(NO_SUBDIR) echo ' ' SUBDIR $$subdir; \
15401541
$(MAKE) $(PRINT_DIR) -C $$subdir
@@ -1780,6 +1781,11 @@ $(SCRIPT_LIB) : % : %.sh GIT-SCRIPT-DEFINES
17801781
$(QUIET_GEN)$(cmd_munge_script) && \
17811782
mv $@+ $@
17821783

1784+
git.res: git.rc GIT-VERSION-FILE
1785+
$(QUIET_RC)$(RC) \
1786+
$(join -DMAJOR= -DMINOR= -DPATCH=, $(wordlist 1,3,$(subst -, ,$(subst ., ,$(GIT_VERSION))))) \
1787+
-DGIT_VERSION="\\\"$(GIT_VERSION)\\\"" $< -o $@
1788+
17831789
ifndef NO_PERL
17841790
$(patsubst %.perl,%,$(SCRIPT_PERL)): perl/perl.mak
17851791

@@ -2480,7 +2486,7 @@ profile-clean:
24802486
$(RM) $(addsuffix *.gcno,$(addprefix $(PROFILE_DIR)/, $(object_dirs)))
24812487

24822488
clean: profile-clean coverage-clean
2483-
$(RM) *.o block-sha1/*.o ppc/*.o compat/*.o compat/*/*.o xdiff/*.o vcs-svn/*.o \
2489+
$(RM) *.o *.res block-sha1/*.o ppc/*.o compat/*.o compat/*/*.o xdiff/*.o vcs-svn/*.o \
24842490
builtin/*.o $(LIB_FILE) $(XDIFF_LIB) $(VCSSVN_LIB)
24852491
$(RM) $(ALL_PROGRAMS) $(SCRIPT_LIB) $(BUILT_INS) git$X
24862492
$(RM) $(TEST_PROGRAMS)

config.mak.uname

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -481,7 +481,6 @@ ifneq (,$(findstring MINGW,$(uname_S)))
481481
NO_FNMATCH = YesPlease
482482
NO_MEMMEM = YesPlease
483483
NEEDS_LIBICONV = YesPlease
484-
OLD_ICONV = YesPlease
485484
NO_STRTOUMAX = YesPlease
486485
NO_MKDTEMP = YesPlease
487486
NO_MKSTEMPS = YesPlease
@@ -501,13 +500,17 @@ ifneq (,$(findstring MINGW,$(uname_S)))
501500
NO_INET_PTON = YesPlease
502501
NO_INET_NTOP = YesPlease
503502
NO_POSIX_GOODIES = UnfortunatelyYes
503+
DEFAULT_HELP_FORMAT = html
504504
COMPAT_CFLAGS += -D__USE_MINGW_ACCESS -DNOGDI -Icompat -Icompat/win32
505505
COMPAT_CFLAGS += -DSTRIP_EXTENSION=\".exe\"
506506
COMPAT_OBJS += compat/mingw.o compat/winansi.o \
507507
compat/win32/pthread.o compat/win32/syslog.o \
508508
compat/win32/dirent.o
509+
BASIC_LDFLAGS += -Wl,--large-address-aware
509510
EXTLIBS += -lws2_32
511+
GITLIBS += git.res
510512
PTHREAD_LIBS =
513+
RC = windres -O coff
511514
NATIVE_CRLF = YesPlease
512515
X = .exe
513516
SPARSE_FLAGS = -Wno-one-bit-signed-bitfield
@@ -519,6 +522,7 @@ ifneq (,$(wildcard ../THIS_IS_MSYSGIT))
519522
NO_R_TO_GCC_LINKER = YesPlease
520523
INTERNAL_QSORT = YesPlease
521524
HAVE_LIBCHARSET_H = YesPlease
525+
NO_GETTEXT = YesPlease
522526
else
523527
NO_CURL = YesPlease
524528
endif

git.rc

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
1 VERSIONINFO
2+
FILEVERSION MAJOR,MINOR,PATCH,0
3+
PRODUCTVERSION MAJOR,MINOR,PATCH,0
4+
BEGIN
5+
BLOCK "StringFileInfo"
6+
BEGIN
7+
BLOCK "040904b0" /* LANG_ENGLISH/SUBLANG_ENGLISH_US, Unicode CP */
8+
BEGIN
9+
VALUE "CompanyName", "The Git Development Community\0"
10+
VALUE "FileDescription", "Git for Windows\0"
11+
VALUE "InternalName", "git\0"
12+
VALUE "OriginalFilename", "git.exe\0"
13+
VALUE "ProductName", "Git\0"
14+
VALUE "ProductVersion", GIT_VERSION "\0"
15+
END
16+
END
17+
18+
BLOCK "VarFileInfo"
19+
BEGIN
20+
VALUE "Translation", 0x409, 1200
21+
END
22+
END

0 commit comments

Comments
 (0)