setup: free old value before setting work_tree

Martin Ågren · gitster · commit 13019979b811 · 2019-01-23T13:15:58.000-08:00
Before assigning to `data-&gt;work_tree` in `read_worktree_config()`, free
any value we might already have picked up, so that we do not leak it.

Signed-off-by: Martin Ågren &lt;martin.agren@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/setup.c b/setup.c
@@ -411,6 +411,7 @@ static int read_worktree_config(const char *var, const char *value, void *vdata)
 	} else if (strcmp(var, "core.worktree") == 0) {
 		if (!value)
 			return config_error_nonbool(var);
+		free(data->work_tree);
 		data->work_tree = xstrdup(value);
 	}
 	return 0;

Original file line number	Diff line number	Diff line change
`@@ -411,6 +411,7 @@ static int read_worktree_config(const char var, const char value, void *vdata)`
`411`	`411`	`} else if (strcmp(var, "core.worktree") == 0) {`
`412`	`412`	`if (!value)`
`413`	`413`	`return config_error_nonbool(var);`
	`414`	`+ free(data->work_tree);`
`414`	`415`	`data->work_tree = xstrdup(value);`
`415`	`416`	`}`
`416`	`417`	`return 0;`