Merge branch 'fix'

Junio C Hamano · Junio C Hamano · commit 12d81ce59846 · 2006-04-05T02:50:54.000-07:00
* fix:
  diff_flush(): leakfix.
  parse_date(): fix parsing 03/10/2006
diff --git a/date.c b/date.c
@@ -255,10 +255,10 @@ static int match_multi_number(unsigned long num, char c, const char *date, char
 				break;
 		}
 		/* mm/dd/yy ? */
-		if (is_date(num3, num2, num, tm))
+		if (is_date(num3, num, num2, tm))
 			break;
 		/* dd/mm/yy ? */
-		if (is_date(num3, num, num2, tm))
+		if (is_date(num3, num2, num, tm))
 			break;
 		return 0;
 	}
diff --git a/diff.c b/diff.c
@@ -1280,28 +1280,34 @@ void diff_flush(struct diff_options *options)
 
 	for (i = 0; i < q->nr; i++) {
 		struct diff_filepair *p = q->queue[i];
-		if ((diff_output_format == DIFF_FORMAT_NO_OUTPUT) ||
-		    (p->status == DIFF_STATUS_UNKNOWN))
-			continue;
-		if (p->status == 0)
-			die("internal error in diff-resolve-rename-copy");
-		switch (diff_output_format) {
-		case DIFF_FORMAT_PATCH:
-			diff_flush_patch(p, options);
-			break;
-		case DIFF_FORMAT_RAW:
-		case DIFF_FORMAT_NAME_STATUS:
-			diff_flush_raw(p, line_termination,
-				       inter_name_termination,
-				       options);
+
+		switch (p->status) {
+		case DIFF_STATUS_UNKNOWN:
 			break;
-		case DIFF_FORMAT_NAME:
-			diff_flush_name(p,
-					inter_name_termination,
-					line_termination);
+		case 0:
+			die("internal error in diff-resolve-rename-copy");
 			break;
+		default:
+			switch (diff_output_format) {
+			case DIFF_FORMAT_PATCH:
+				diff_flush_patch(p, options);
+				break;
+			case DIFF_FORMAT_RAW:
+			case DIFF_FORMAT_NAME_STATUS:
+				diff_flush_raw(p, line_termination,
+					       inter_name_termination,
+					       options);
+				break;
+			case DIFF_FORMAT_NAME:
+				diff_flush_name(p,
+						inter_name_termination,
+						line_termination);
+				break;
+			case DIFF_FORMAT_NO_OUTPUT:
+				break;
+			}
 		}
-		diff_free_filepair(q->queue[i]);
+		diff_free_filepair(p);
 	}
 	free(q->queue);
 	q->queue = NULL;

Original file line number	Diff line number	Diff line change
`@@ -255,10 +255,10 @@ static int match_multi_number(unsigned long num, char c, const char *date, char`
`255`	`255`	`break;`
`256`	`256`	`}`
`257`	`257`	`/* mm/dd/yy ? */`
`258`		`- if (is_date(num3, num2, num, tm))`
	`258`	`+ if (is_date(num3, num, num2, tm))`
`259`	`259`	`break;`
`260`	`260`	`/* dd/mm/yy ? */`
`261`		`- if (is_date(num3, num, num2, tm))`
	`261`	`+ if (is_date(num3, num2, num, tm))`
`262`	`262`	`break;`
`263`	`263`	`return 0;`
`264`	`264`	`}`