transport-helper: die early on encountering deleted refs

SRabbelier · gitster · commit 105fe3e457fb · 2011-07-19T11:17:48.000-07:00
Remote helpers do not support deleting refs by means of the 'export'
command sincethe fast-import protocol does not support it.

Check explicitly for deleted refs and die early.

Signed-off-by: Sverre Rabbelier &lt;srabbelier@gmail.com&gt;
Acked-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/transport-helper.c b/transport-helper.c
@@ -746,6 +746,10 @@ static int push_refs_with_export(struct transport *transport,
 		}
 		free(private);
 
+		if (ref->deletion) {
+			die("remote-helpers do not support ref deletion");
+		}
+
 		if (ref->peer_ref)
 			string_list_append(&revlist_args, ref->peer_ref->name);
 

Original file line number	Diff line number	Diff line change
`@@ -746,6 +746,10 @@ static int push_refs_with_export(struct transport *transport,`
`746`	`746`	`}`
`747`	`747`	`free(private);`
`748`	`748`
	`749`	`+ if (ref->deletion) {`
	`750`	`+ die("remote-helpers do not support ref deletion");`
	`751`	`+ }`
	`752`	`+`
`749`	`753`	`if (ref->peer_ref)`
`750`	`754`	`string_list_append(&revlist_args, ref->peer_ref->name);`
`751`	`755`