pkt-line: extern packet_length()

Denton-L · gitster · commit 101736a14c9a · 2020-05-19T15:40:26.000-07:00
In a future commit, we will be manually processing packets and we will
need to access the length header. In order to simplify this, extern
packet_length() so that the logic can be reused.

Change the function parameter from `const char *linelen` to
`const char lenbuf_hex[4]`. Even though these two types behave
identically as function parameters, use the array notation to
semantically indicate exactly what this function is expecting as an
argument. Also, rename it from linelen to lenbuf_hex as the former
sounds like it should be an integral type which is misleading.

Signed-off-by: Denton Liu &lt;liu.denton@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/pkt-line.c b/pkt-line.c
@@ -306,10 +306,10 @@ static int get_packet_data(int fd, char **src_buf, size_t *src_size,
 	return ret;
 }
 
-static int packet_length(const char *linelen)
+int packet_length(const char lenbuf_hex[4])
 {
-	int val = hex2chr(linelen);
-	return (val < 0) ? val : (val << 8) | hex2chr(linelen + 2);
+	int val = hex2chr(lenbuf_hex);
+	return (val < 0) ? val : (val << 8) | hex2chr(lenbuf_hex + 2);
 }
 
 enum packet_read_status packet_read_with_status(int fd, char **src_buffer,
diff --git a/pkt-line.h b/pkt-line.h
@@ -74,6 +74,15 @@ int write_packetized_from_buf(const char *src_in, size_t len, int fd_out);
 int packet_read(int fd, char **src_buffer, size_t *src_len, char
 		*buffer, unsigned size, int options);
 
+/*
+ * Convert a four hex digit packet line length header into its numeric
+ * representation.
+ *
+ * If lenbuf_hex contains non-hex characters, return -1. Otherwise, return the
+ * numeric value of the length header.
+ */
+int packet_length(const char lenbuf_hex[4]);
+
 /*
  * Read a packetized line into a buffer like the 'packet_read()' function but
  * returns an 'enum packet_read_status' which indicates the status of the read.

Original file line number	Diff line number	Diff line change
`@@ -306,10 +306,10 @@ static int get_packet_data(int fd, char *src_buf, size_t src_size,`
`306`	`306`	`return ret;`
`307`	`307`	`}`
`308`	`308`
`309`		`-static int packet_length(const char *linelen)`
	`309`	`+int packet_length(const char lenbuf_hex[4])`
`310`	`310`	`{`
`311`		`- int val = hex2chr(linelen);`
`312`		`- return (val < 0) ? val : (val << 8) \| hex2chr(linelen + 2);`
	`311`	`+ int val = hex2chr(lenbuf_hex);`
	`312`	`+ return (val < 0) ? val : (val << 8) \| hex2chr(lenbuf_hex + 2);`
`313`	`313`	`}`
`314`	`314`
`315`	`315`	`enum packet_read_status packet_read_with_status(int fd, char **src_buffer,`