t9902-completion.sh: old Bash still does not support array+=('') notation

drafnel · gitster · commit 0ef09702d6b7 · 2013-08-21T16:38:50.000-07:00
Old Bash (3.0) which is distributed with RHEL 4.X and other ancient
platforms that are still in wide use, does not understand the
array+=() notation.  Let's use an explicit assignment to the new array
element which works everywhere, like:

   array[${#array[@]}+1]=''

The right-hand side '' is not strictly necessary, but in this case
I think it is more clear.

Signed-off-by: Brandon Casey &lt;drafnel@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
@@ -69,7 +69,7 @@ run_completion ()
 	local -a COMPREPLY _words
 	local _cword
 	_words=( $1 )
-	test "${1: -1}" = ' ' && _words+=('')
+	test "${1: -1}" = ' ' && _words[${#_words[@]}+1]=''
 	(( _cword = ${#_words[@]} - 1 ))
 	__git_wrap__git_main && print_comp
 }

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ run_completion ()`
`69`	`69`	`local -a COMPREPLY _words`
`70`	`70`	`local _cword`
`71`	`71`	`_words=( $1 )`
`72`		`- test "${1: -1}" = ' ' && _words+=('')`
	`72`	`+ test "${1: -1}" = ' ' && _words[${#_words[@]}+1]=''`
`73`	`73`	`(( _cword = ${#_words[@]} - 1 ))`
`74`	`74`	`__git_wrap__git_main && print_comp`
`75`	`75`	`}`