tag: add repository argument to parse_tag_buffer

stefanbeller · gitster · commit 0e740fed5dfd · 2018-06-29T10:43:39.000-07:00
Add a repository argument to allow the callers of parse_tag_buffer
to be more specific about which repository to act on. This is a small
mechanical change; it doesn't change the implementation to handle
repositories other than the_repository yet.

As with the previous commits, use a macro to catch callers passing a
repository other than the_repository at compile time.

Signed-off-by: Jonathan Nieder &lt;jrnieder@gmail.com&gt;
Signed-off-by: Stefan Beller &lt;sbeller@google.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/replace.c b/builtin/replace.c
@@ -405,7 +405,7 @@ static int check_one_mergetag(struct commit *commit,
 	tag = lookup_tag(the_repository, &tag_oid);
 	if (!tag)
 		return error(_("bad mergetag in commit '%s'"), ref);
-	if (parse_tag_buffer(tag, extra->value, extra->len))
+	if (parse_tag_buffer(the_repository, tag, extra->value, extra->len))
 		return error(_("malformed mergetag in commit '%s'"), ref);
 
 	/* iterate over new parents */
diff --git a/log-tree.c b/log-tree.c
@@ -503,7 +503,7 @@ static int show_one_mergetag(struct commit *commit,
 		return -1; /* error message already given */
 
 	strbuf_init(&verify_message, 256);
-	if (parse_tag_buffer(tag, extra->value, extra->len))
+	if (parse_tag_buffer(the_repository, tag, extra->value, extra->len))
 		strbuf_addstr(&verify_message, "malformed mergetag\n");
 	else if (is_common_merge(commit) &&
 		 !oidcmp(&tag->tagged->oid,
diff --git a/object.c b/object.c
@@ -225,7 +225,7 @@ struct object *parse_object_buffer_the_repository(const struct object_id *oid, e
 	} else if (type == OBJ_TAG) {
 		struct tag *tag = lookup_tag(the_repository, oid);
 		if (tag) {
-			if (parse_tag_buffer(tag, buffer, size))
+			if (parse_tag_buffer(the_repository, tag, buffer, size))
 			       return NULL;
 			obj = &tag->object;
 		}
diff --git a/sha1-file.c b/sha1-file.c
@@ -1809,7 +1809,7 @@ static void check_tag(const void *buf, size_t size)
 {
 	struct tag t;
 	memset(&t, 0, sizeof(t));
-	if (parse_tag_buffer(&t, buf, size))
+	if (parse_tag_buffer(the_repository, &t, buf, size))
 		die("corrupt tag");
 }
 
diff --git a/tag.c b/tag.c
@@ -126,7 +126,7 @@ void release_tag_memory(struct tag *t)
 	t->date = 0;
 }
 
-int parse_tag_buffer(struct tag *item, const void *data, unsigned long size)
+int parse_tag_buffer_the_repository(struct tag *item, const void *data, unsigned long size)
 {
 	struct object_id oid;
 	char type[20];
@@ -203,7 +203,7 @@ int parse_tag(struct tag *item)
 		return error("Object %s not a tag",
 			     oid_to_hex(&item->object.oid));
 	}
-	ret = parse_tag_buffer(item, data, size);
+	ret = parse_tag_buffer(the_repository, item, data, size);
 	free(data);
 	return ret;
 }
diff --git a/tag.h b/tag.h
@@ -13,7 +13,8 @@ struct tag {
 };
 #define lookup_tag(r, o) lookup_tag_##r(o)
 extern struct tag *lookup_tag_the_repository(const struct object_id *oid);
-extern int parse_tag_buffer(struct tag *item, const void *data, unsigned long size);
+#define parse_tag_buffer(r, i, d, s) parse_tag_buffer_##r(i, d, s)
+extern int parse_tag_buffer_the_repository(struct tag *item, const void *data, unsigned long size);
 extern int parse_tag(struct tag *item);
 extern void release_tag_memory(struct tag *t);
 extern struct object *deref_tag(struct object *, const char *, int);

Original file line number	Diff line number	Diff line change
`@@ -225,7 +225,7 @@ struct object parse_object_buffer_the_repository(const struct object_id oid, e`
`225`	`225`	`} else if (type == OBJ_TAG) {`
`226`	`226`	`struct tag *tag = lookup_tag(the_repository, oid);`
`227`	`227`	`if (tag) {`
`228`		`- if (parse_tag_buffer(tag, buffer, size))`
	`228`	`+ if (parse_tag_buffer(the_repository, tag, buffer, size))`
`229`	`229`	`return NULL;`
`230`	`230`	`obj = &tag->object;`
`231`	`231`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1809,7 +1809,7 @@ static void check_tag(const void *buf, size_t size)`
`1809`	`1809`	`{`
`1810`	`1810`	`struct tag t;`
`1811`	`1811`	`memset(&t, 0, sizeof(t));`
`1812`		`- if (parse_tag_buffer(&t, buf, size))`
	`1812`	`+ if (parse_tag_buffer(the_repository, &t, buf, size))`
`1813`	`1813`	`die("corrupt tag");`
`1814`	`1814`	`}`
`1815`	`1815`
Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ void release_tag_memory(struct tag *t)`
`126`	`126`	`t->date = 0;`
`127`	`127`	`}`
`128`	`128`
`129`		`-int parse_tag_buffer(struct tag item, const void data, unsigned long size)`
	`129`	`+int parse_tag_buffer_the_repository(struct tag item, const void data, unsigned long size)`
`130`	`130`	`{`
`131`	`131`	`struct object_id oid;`
`132`	`132`	`char type[20];`
`@@ -203,7 +203,7 @@ int parse_tag(struct tag *item)`
`203`	`203`	`return error("Object %s not a tag",`
`204`	`204`	`oid_to_hex(&item->object.oid));`
`205`	`205`	`}`
`206`		`- ret = parse_tag_buffer(item, data, size);`
	`206`	`+ ret = parse_tag_buffer(the_repository, item, data, size);`
`207`	`207`	`free(data);`
`208`	`208`	`return ret;`
`209`	`209`	`}`