Skip to content

Commit 0e2d29b

Browse files
committed
Meta/cook: leave a NEEDSWORK comment
A new topic that is still not ready for 'pu' which uses a topic in flight appear in the description of the latter as "used by", even though it does not appear in the report anywhere else. Leave a note to the place where this bug happens, as I do not have time to fix it right now.
1 parent ca00d43 commit 0e2d29b

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

cook

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,15 @@ sub get_commit {
250250
}
251251

252252
my $list = join("\n", map { " " . $_ } @desc);
253+
254+
# NEEDSWORK:
255+
# This is done a bit too early. We grabbed all
256+
# under refs/heads/??/* without caring if they are
257+
# merged to 'pu' yet, and it is correct because
258+
# we want to describe a topic that is in the old
259+
# edition that is tentatively kicked out of 'pu'.
260+
# However, we do not want to say a topic is used
261+
# by a new topic that is not yet in 'pu'!
253262
my $relation = describe_relation($topic{$branch});
254263
$topic{$branch}{'desc'} = $head . $list;
255264
if ($relation) {

0 commit comments

Comments
 (0)