run-command: use ALLOC_ARRAY

rscharfe · gitster · commit 0e187d758cd4 · 2017-10-03T08:42:57.000+09:00
Use the macro ALLOC_ARRAY to allocate an array.  This is shorter and
easier, as it automatically infers the size of elements.

Patch generated with Coccinelle and contrib/coccinelle/array.cocci.

Signeg-off-by: Rene Scharfe &lt;l.s.r@web.de&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/run-command.c b/run-command.c
@@ -452,7 +452,7 @@ static char **prep_childenv(const char *const *deltaenv)
 	}
 
 	/* Create an array of 'char *' to be used as the childenv */
-	childenv = xmalloc((env.nr + 1) * sizeof(char *));
+	ALLOC_ARRAY(childenv, env.nr + 1);
 	for (i = 0; i < env.nr; i++)
 		childenv[i] = env.items[i].util;
 	childenv[env.nr] = NULL;

Original file line number	Diff line number	Diff line change
`@@ -452,7 +452,7 @@ static char *prep_childenv(const char const *deltaenv)`
`452`	`452`	`}`
`453`	`453`
`454`	`454`	`/* Create an array of 'char ' to be used as the childenv /`
`455`		`- childenv = xmalloc((env.nr + 1) * sizeof(char *));`
	`455`	`+ ALLOC_ARRAY(childenv, env.nr + 1);`
`456`	`456`	`for (i = 0; i < env.nr; i++)`
`457`	`457`	`childenv[i] = env.items[i].util;`
`458`	`458`	`childenv[env.nr] = NULL;`