sequencer: unlink autostash in apply_autostash()

Denton-L · gitster · commit 0dd562e0f7c0 · 2020-04-10T09:28:02.000-07:00
Explicitly remove autostash file in apply_autostash() once it has been
applied successfully.

This is currently a no-op because the only users of this function will unlink
the state (including the autostash file) after this function runs.
However, in the future, we will introduce a user of the function that
does not explicitly remove the state so we do it here.

Signed-off-by: Denton Liu &lt;liu.denton@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/sequencer.c b/sequencer.c
@@ -3748,6 +3748,7 @@ int apply_autostash(const char *path)
 				  " \"git stash drop\" at any time.\n"));
 	}
 
+	unlink(path);
 	strbuf_release(&stash_oid);
 	return ret;
 }

Original file line number	Diff line number	Diff line change
`@@ -3748,6 +3748,7 @@ int apply_autostash(const char *path)`
`3748`	`3748`	`" \"git stash drop\" at any time.\n"));`
`3749`	`3749`	`}`
`3750`	`3750`
	`3751`	`+ unlink(path);`
`3751`	`3752`	`strbuf_release(&stash_oid);`
`3752`	`3753`	`return ret;`
`3753`	`3754`	`}`