config.c: mark file-local function static

Ramsay Jones · jrn · commit 0b4dc66169da · 2013-10-14T16:00:37.000-07:00
Commit 7192777 refactors git_parse_ulong, which is public, into a more
generic function.  But since we kept the git_parse_ulong wrapper, only
that part needs to be public; nobody outside the file calls the
lower-level git_parse_unsigned.

Noticed with sparse.  ("'git_parse_unsigned' was not declared. Should
it be static?")

Signed-off-by: Ramsay Jones &lt;ramsay@ramsay1.demon.co.uk&gt;
Explained-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Jonathan Nieder &lt;jrnieder@gmail.com&gt;
diff --git a/config.c b/config.c
@@ -498,7 +498,7 @@ static int git_parse_signed(const char *value, intmax_t *ret, intmax_t max)
 	return 0;
 }
 
-int git_parse_unsigned(const char *value, uintmax_t *ret, uintmax_t max)
+static int git_parse_unsigned(const char *value, uintmax_t *ret, uintmax_t max)
 {
 	if (value && *value) {
 		char *end;

Original file line number	Diff line number	Diff line change
`@@ -498,7 +498,7 @@ static int git_parse_signed(const char value, intmax_t ret, intmax_t max)`
`498`	`498`	`return 0;`
`499`	`499`	`}`
`500`	`500`
`501`		`-int git_parse_unsigned(const char value, uintmax_t ret, uintmax_t max)`
	`501`	`+static int git_parse_unsigned(const char value, uintmax_t ret, uintmax_t max)`
`502`	`502`	`{`
`503`	`503`	`if (value && *value) {`
`504`	`504`	`char *end;`