remote-mediawiki: show known namespace choices on failure

anarcat · gitster · commit 09eebbadca58 · 2017-11-08T11:06:33.000+09:00
If we fail to find a requested namespace, we should tell the user
which ones we know about, since those were already fetched. This
allows users to fetch all namespaces by specifying a dummy namespace,
failing, then copying the list of namespaces in the config.

Eventually, we should have a flag that allows fetching all namespaces
automatically.

Reviewed-by: Antoine Beaupré &lt;anarcat@debian.org&gt;
Signed-off-by: Antoine Beaupré &lt;anarcat@debian.org&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl
@@ -1334,7 +1334,8 @@ sub get_mw_namespace_id {
 	my $id;
 
 	if (!defined $ns) {
-		print {*STDERR} "No such namespace ${name} on MediaWiki.\n";
+		my @namespaces = map { s/ /_/g; $_; } sort keys %namespace_id;
+		print {*STDERR} "No such namespace ${name} on MediaWiki, known namespaces: @namespaces\n";
 		$ns = {is_namespace => 0};
 		$namespace_id{$name} = $ns;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1334,7 +1334,8 @@ sub get_mw_namespace_id {`
`1334`	`1334`	`my $id;`
`1335`	`1335`
`1336`	`1336`	`if (!defined $ns) {`
`1337`		`- print {*STDERR} "No such namespace ${name} on MediaWiki.\n";`
	`1337`	`+ my @namespaces = map { s/ /_/g; $_; } sort keys %namespace_id;`
	`1338`	`+ print {*STDERR} "No such namespace ${name} on MediaWiki, known namespaces: @namespaces\n";`
`1338`	`1339`	`$ns = {is_namespace => 0};`
`1339`	`1340`	`$namespace_id{$name} = $ns;`
`1340`	`1341`	`}`