Skip to content

Commit 0960f7d

Browse files
committed
git-gui: Stop deleting gitk preferences.
Now that git 1.5.0 and later contains a version of gitk that uses correct geometry on Windows platforms, even if ~/.gitk exists, we should not delete the user's ~/.gitk to work around the bug. It is downright mean to remove a user's preferences for another app. Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
1 parent d585e78 commit 0960f7d

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

git-gui.sh

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4015,14 +4015,6 @@ set starting_gitk_msg {Starting gitk... please wait...}
40154015
proc do_gitk {revs} {
40164016
global env ui_status_value starting_gitk_msg
40174017

4018-
# -- On Windows gitk is severly broken, and right now it seems like
4019-
# nobody cares about fixing it. The only known workaround is to
4020-
# always delete ~/.gitk before starting the program.
4021-
#
4022-
if {[is_Windows]} {
4023-
catch {file delete [file join $env(HOME) .gitk]}
4024-
}
4025-
40264018
# -- Always start gitk through whatever we were loaded with. This
40274019
# lets us bypass using shell process on Windows systems.
40284020
#

0 commit comments

Comments
 (0)