git-gui: Paper bag fix info dialog when no files are staged at commit

spearce · spearce · commit 094fbbf96415 · 2008-02-28T01:28:45.000-05:00
If the user tries to commit their changes without actually staging anything we used to display an informational dialog suggesting they first stage those changes, then retry the commit feature. Unfortunately I broke this in aba15f7 ("Ensure error dialogs always appear over all other windows") and failed to fix it in the paper bag fix that came one day after it. Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
diff --git a/lib/error.tcl b/lib/error.tcl
@@ -47,7 +47,7 @@ proc info_popup {msg} {
 		append title " ([reponame])"
 	}
 	tk_messageBox \
-		-parent $parent \
+		-parent [_error_parent] \
 		-icon info \
 		-type ok \
 		-title $title \

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ proc info_popup {msg} {`
`47`	`47`	`append title " ([reponame])"`
`48`	`48`	`}`
`49`	`49`	`tk_messageBox \`
`50`		`- -parent $parent \`
	`50`	`+ -parent [_error_parent] \`
`51`	`51`	`-icon info \`
`52`	`52`	`-type ok \`
`53`	`53`	`-title $title \`