t5612: don't use test_must_fail test_cmp

Denton-L · gitster · commit 0813dd28b948 · 2020-03-27T10:56:40.000-07:00
The test_must_fail function should only be used for git commands since
we should assume that external commands work sanely. Since test_cmp() just
wraps an external command, replace `test_must_fail test_cmp` with
`! test_cmp`.

Signed-off-by: Denton Liu &lt;liu.denton@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/t5612-clone-refspec.sh b/t/t5612-clone-refspec.sh
@@ -87,7 +87,7 @@ test_expect_success 'by default no tags will be kept updated' '
 		git for-each-ref refs/tags >../actual
 	) &&
 	git for-each-ref refs/tags >expect &&
-	test_must_fail test_cmp expect actual &&
+	! test_cmp expect actual &&
 	test_line_count = 2 actual
 '
 

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ test_expect_success 'by default no tags will be kept updated' '`
`87`	`87`	`git for-each-ref refs/tags >../actual`
`88`	`88`	`) &&`
`89`	`89`	`git for-each-ref refs/tags >expect &&`
`90`		`- test_must_fail test_cmp expect actual &&`
	`90`	`+ ! test_cmp expect actual &&`
`91`	`91`	`test_line_count = 2 actual`
`92`	`92`	`'`
`93`	`93`