receive-pack: reject invalid refnames

Martin Koegler · gitster · commit 061d6b9a7bfc · 2008-01-04T15:59:43.000-08:00
Signed-off-by: Martin Koegler &lt;mkoegler@auto.tuwien.ac.at&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/receive-pack.c b/receive-pack.c
@@ -165,7 +165,8 @@ static const char *update(struct command *cmd)
 	unsigned char *new_sha1 = cmd->new_sha1;
 	struct ref_lock *lock;
 
-	if (!prefixcmp(name, "refs/") && check_ref_format(name + 5)) {
+	/* only refs/... are allowed */
+	if (prefixcmp(name, "refs/") || check_ref_format(name + 5)) {
 		error("refusing to create funny ref '%s' remotely", name);
 		return "funny refname";
 	}

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,8 @@ static const char update(struct command cmd)`
`165`	`165`	`unsigned char *new_sha1 = cmd->new_sha1;`
`166`	`166`	`struct ref_lock *lock;`
`167`	`167`
`168`		`- if (!prefixcmp(name, "refs/") && check_ref_format(name + 5)) {`
	`168`	`+ /* only refs/... are allowed */`
	`169`	`+ if (prefixcmp(name, "refs/") \|\| check_ref_format(name + 5)) {`
`169`	`170`	`error("refusing to create funny ref '%s' remotely", name);`
`170`	`171`	`return "funny refname";`
`171`	`172`	`}`