clone: teach recursive clones to respect -q

bmwill · gitster · commit 03c004c581fb · 2017-08-04T09:08:37.000-07:00
Teach 'git clone --recurse-submodules' to respect the '-q' option by
passing down the quiet flag to the process which handles cloning of
submodules.

Signed-off-by: Brandon Williams &lt;bmwill@google.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/clone.c b/builtin/clone.c
@@ -764,6 +764,9 @@ static int checkout(int submodule_progress)
 		if (submodule_progress)
 			argv_array_push(&args, "--progress");
 
+		if (option_verbosity < 0)
+			argv_array_push(&args, "--quiet");
+
 		err = run_command_v_opt(args.argv, RUN_GIT_CMD);
 		argv_array_clear(&args);
 	}
diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh
@@ -1289,4 +1289,10 @@ test_expect_success 'init properly sets the config' '
 	test_must_fail git -C multisuper_clone config --get submodule.sub1.active
 '
 
+test_expect_success 'recursive clone respects -q' '
+	test_when_finished "rm -rf multisuper_clone" &&
+	git clone -q --recurse-submodules multisuper multisuper_clone >actual &&
+	test_must_be_empty actual
+'
+
 test_done

Original file line number	Diff line number	Diff line change
`@@ -764,6 +764,9 @@ static int checkout(int submodule_progress)`
`764`	`764`	`if (submodule_progress)`
`765`	`765`	`argv_array_push(&args, "--progress");`
`766`	`766`
	`767`	`+ if (option_verbosity < 0)`
	`768`	`+ argv_array_push(&args, "--quiet");`
	`769`	`+`
`767`	`770`	`err = run_command_v_opt(args.argv, RUN_GIT_CMD);`
`768`	`771`	`argv_array_clear(&args);`
`769`	`772`	`}`