Skip to content

Commit 024bb12

Browse files
spearcegitster
authored andcommitted
http tests: use /dumb/ URL prefix
To clarify what part of the HTTP transprot is being tested we change the URLs used by existing tests to include /dumb/ at the start, indicating they use the non-Git aware code paths. Signed-off-by: Shawn O. Pearce <spearce@spearce.org> CC: Tay Ray Chuan <rctay89@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 859d1fb commit 024bb12

File tree

3 files changed

+13
-8
lines changed

3 files changed

+13
-8
lines changed

t/lib-httpd/apache.conf

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,11 @@ ErrorLog error.log
88
<IfModule !mod_log_config.c>
99
LoadModule log_config_module modules/mod_log_config.so
1010
</IfModule>
11+
<IfModule !mod_alias.c>
12+
LoadModule alias_module modules/mod_alias.so
13+
</IfModule>
14+
15+
Alias /dumb/ www/
1116

1217
<IfDefine SSL>
1318
LoadModule ssl_module modules/mod_ssl.so
@@ -26,7 +31,7 @@ SSLEngine On
2631
LoadModule dav_fs_module modules/mod_dav_fs.so
2732

2833
DAVLockDB DAVLock
29-
<Location />
34+
<Location /dumb/>
3035
Dav on
3136
</Location>
3237
</IfDefine>

t/t5540-http-push.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ test_expect_success 'setup remote repository' '
4242

4343
test_expect_success 'clone remote repository' '
4444
cd "$ROOT_PATH" &&
45-
git clone $HTTPD_URL/test_repo.git test_repo_clone
45+
git clone $HTTPD_URL/dumb/test_repo.git test_repo_clone
4646
'
4747

4848
test_expect_success 'push to remote repository with packed refs' '
@@ -75,7 +75,7 @@ test_expect_success 'http-push fetches unpacked objects' '
7575
cp -R "$HTTPD_DOCUMENT_ROOT_PATH"/test_repo.git \
7676
"$HTTPD_DOCUMENT_ROOT_PATH"/test_repo_unpacked.git &&
7777
78-
git clone $HTTPD_URL/test_repo_unpacked.git \
78+
git clone $HTTPD_URL/dumb/test_repo_unpacked.git \
7979
"$ROOT_PATH"/fetch_unpacked &&
8080
8181
# By reset, we force git to retrieve the object
@@ -84,14 +84,14 @@ test_expect_success 'http-push fetches unpacked objects' '
8484
git remote rm origin &&
8585
git reflog expire --expire=0 --all &&
8686
git prune &&
87-
git push -f -v $HTTPD_URL/test_repo_unpacked.git master)
87+
git push -f -v $HTTPD_URL/dumb/test_repo_unpacked.git master)
8888
'
8989

9090
test_expect_success 'http-push fetches packed objects' '
9191
cp -R "$HTTPD_DOCUMENT_ROOT_PATH"/test_repo.git \
9292
"$HTTPD_DOCUMENT_ROOT_PATH"/test_repo_packed.git &&
9393
94-
git clone $HTTPD_URL/test_repo_packed.git \
94+
git clone $HTTPD_URL/dumb/test_repo_packed.git \
9595
"$ROOT_PATH"/test_repo_clone_packed &&
9696
9797
(cd "$HTTPD_DOCUMENT_ROOT_PATH"/test_repo_packed.git &&
@@ -104,7 +104,7 @@ test_expect_success 'http-push fetches packed objects' '
104104
git remote rm origin &&
105105
git reflog expire --expire=0 --all &&
106106
git prune &&
107-
git push -f -v $HTTPD_URL/test_repo_packed.git master)
107+
git push -f -v $HTTPD_URL/dumb/test_repo_packed.git master)
108108
'
109109

110110
test_expect_success 'create and delete remote branch' '

t/t5550-http-fetch.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ test_expect_success 'create http-accessible bare repository' '
3030
'
3131

3232
test_expect_success 'clone http repository' '
33-
git clone $HTTPD_URL/repo.git clone &&
33+
git clone $HTTPD_URL/dumb/repo.git clone &&
3434
test_cmp file clone/file
3535
'
3636

@@ -58,7 +58,7 @@ test_expect_success 'fetch packed objects' '
5858
cd "$HTTPD_DOCUMENT_ROOT_PATH"/repo_pack.git &&
5959
git --bare repack &&
6060
git --bare prune-packed &&
61-
git clone $HTTPD_URL/repo_pack.git
61+
git clone $HTTPD_URL/dumb/repo_pack.git
6262
'
6363

6464
stop_httpd

0 commit comments

Comments
 (0)