t/helper/ref-store: initialize oid in resolve-ref

hanwen · gitster · commit 0221eb86782b · 2021-06-02T10:01:54.000+09:00
This will print $ZERO_OID when asking for a non-existent ref from the
test-helper.

Since resolve-ref provides direct access to refs_resolve_ref_unsafe(), it
provides a reliable mechanism for accessing REFNAME, while avoiding the implicit
resolution to refs/heads/REFNAME.

Reviewed-by: Ævar Arnfjörð Bjarmason &lt;avarab@gmail.com&gt;
Signed-off-by: Han-Wen Nienhuys &lt;hanwen@google.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/helper/test-ref-store.c b/t/helper/test-ref-store.c
@@ -118,7 +118,7 @@ static int cmd_for_each_ref(struct ref_store *refs, const char **argv)
 
 static int cmd_resolve_ref(struct ref_store *refs, const char **argv)
 {
-	struct object_id oid;
+	struct object_id oid = *null_oid();
 	const char *refname = notnull(*argv++, "refname");
 	int resolve_flags = arg_flags(*argv++, "resolve-flags");
 	int flags;

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ static int cmd_for_each_ref(struct ref_store refs, const char *argv)`
`118`	`118`
`119`	`119`	`static int cmd_resolve_ref(struct ref_store refs, const char *argv)`
`120`	`120`	`{`
`121`		`- struct object_id oid;`
	`121`	`+ struct object_id oid = *null_oid();`
`122`	`122`	`const char refname = notnull(argv++, "refname");`
`123`	`123`	`int resolve_flags = arg_flags(*argv++, "resolve-flags");`
`124`	`124`	`int flags;`