remote-curl: fix clone on sha256 repos

Eric Wong · gitster · commit 00bc8390d8cd · 2021-05-12T12:14:44.000+09:00
The remote-https process needs to update it's own instance of `the_repository' when it sees an HTTP(S) remote is using sha256. Without this, parse_oid_hex() fails to handle sha256 OIDs when it's eventually called by parse_fetch(). Tested with: git clone https://yhbt.net/sha256test.git GIT_SMART_HTTP=0 git clone https://yhbt.net/sha256test.git (plain http:// also works) Cloning the URL via git:// required no changes Signed-off-by: Eric Wong <e@80x24.org> Acked-by: brian m. carlson <sandals@crustytoothpaste.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/remote-curl.c b/remote-curl.c
@@ -555,6 +555,8 @@ static void output_refs(struct ref *refs)
 	struct ref *posn;
 	if (options.object_format && options.hash_algo) {
 		printf(":object-format %s\n", options.hash_algo->name);
+		repo_set_hash_algo(the_repository,
+				hash_algo_by_ptr(options.hash_algo));
 	}
 	for (posn = refs; posn; posn = posn->next) {
 		if (posn->symref)

Original file line number	Diff line number	Diff line change
`@@ -555,6 +555,8 @@ static void output_refs(struct ref *refs)`
`555`	`555`	`struct ref *posn;`
`556`	`556`	`if (options.object_format && options.hash_algo) {`
`557`	`557`	`printf(":object-format %s\n", options.hash_algo->name);`
	`558`	`+ repo_set_hash_algo(the_repository,`
	`559`	`+ hash_algo_by_ptr(options.hash_algo));`
`558`	`560`	`}`
`559`	`561`	`for (posn = refs; posn; posn = posn->next) {`
`560`	`562`	`if (posn->symref)`