replace-objects: evaluate replacement refs without using the object store

stefanbeller · gitster · commit 006f3f28af2a · 2017-09-14T15:05:54.000+09:00
Pass DO_FOR_EACH_INCLUDE_BROKEN when iterating over replacement refs
so that the iteration does not require opening the named objects from
the object store. This avoids a dependency cycle between object access
and replace ref iteration.

Moreover the ref subsystem has not been migrated yet to access the
object store via passed in repository objects.  As a result, without
this patch, iterating over replace refs in a repository other than
the_repository it produces errors:

   error: refs/replace/3afabef75c627b894cccc3bcae86837abc7c32fe does not point to a valid object!

Noticed while adapting the object store (and in particular its
evaluation of replace refs) to handle arbitrary repositories.

Signed-off-by: Stefan Beller &lt;sbeller@google.com&gt;
Signed-off-by: Jonathan Nieder &lt;jrnieder@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/refs.c b/refs.c
@@ -1394,7 +1394,7 @@ int for_each_replace_ref(each_ref_fn fn, void *cb_data)
 	return do_for_each_ref(get_main_ref_store(),
 			       git_replace_ref_base, fn,
 			       strlen(git_replace_ref_base),
-			       0, cb_data);
+			       DO_FOR_EACH_INCLUDE_BROKEN, cb_data);
 }
 
 int for_each_namespaced_ref(each_ref_fn fn, void *cb_data)

Original file line number	Diff line number	Diff line change
`@@ -1394,7 +1394,7 @@ int for_each_replace_ref(each_ref_fn fn, void *cb_data)`
`1394`	`1394`	`return do_for_each_ref(get_main_ref_store(),`
`1395`	`1395`	`git_replace_ref_base, fn,`
`1396`	`1396`	`strlen(git_replace_ref_base),`
`1397`		`- 0, cb_data);`
	`1397`	`+ DO_FOR_EACH_INCLUDE_BROKEN, cb_data);`
`1398`	`1398`	`}`
`1399`	`1399`
`1400`	`1400`	`int for_each_namespaced_ref(each_ref_fn fn, void *cb_data)`