socksetup: don't return on set_reuse_addr() error

Serge E. Hallyn · Junio C Hamano · commit 0032d548db56 · 2006-04-18T14:39:28.000-07:00
The set_reuse_addr() error case was the only error case in
socklist() where we returned rather than continued.  Not sure
why.  Either we must free the socklist, or continue.  This patch
continues on error.

Signed-off-by: Serge E. Hallyn &lt;serue@us.ibm.com&gt;
Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
diff --git a/daemon.c b/daemon.c
@@ -535,7 +535,7 @@ static int socksetup(int port, int **socklist_p)
 
 		if (set_reuse_addr(sockfd)) {
 			close(sockfd);
-			return 0;	/* not fatal */
+			continue;
 		}
 
 		if (bind(sockfd, ai->ai_addr, ai->ai_addrlen) < 0) {

Original file line number	Diff line number	Diff line change
`@@ -535,7 +535,7 @@ static int socksetup(int port, int **socklist_p)`
`535`	`535`
`536`	`536`	`if (set_reuse_addr(sockfd)) {`
`537`	`537`	`close(sockfd);`
`538`		`- return 0; /* not fatal */`
	`538`	`+ continue;`
`539`	`539`	`}`
`540`	`540`
`541`	`541`	`if (bind(sockfd, ai->ai_addr, ai->ai_addrlen) < 0) {`