Notifications should emit close on close, not eventual GC

mgc · mgc · commit ca8f45a50194 · 2017-10-27T00:04:19.000-07:00
diff --git a/atom/browser/api/atom_api_notification.cc b/atom/browser/api/atom_api_notification.cc
@@ -169,10 +169,10 @@ void Notification::NotificationDisplayed() {
 }
 
 void Notification::NotificationDestroyed() {
-  Emit("close");
 }
 
 void Notification::NotificationClosed() {
+  Emit("close");
 }
 
 // Showing notifications
diff --git a/docs/api/notification.md b/docs/api/notification.md
@@ -74,7 +74,7 @@ Returns:
 
 Emitted when the notification is closed by manual intervention from the user.
 
-This event is not guarunteed to be emitted in all cases where the notification
+This event is not guaranteed to be emitted in all cases where the notification
 is closed.
 
 #### Event: 'reply' _macOS_

Original file line number	Diff line number	Diff line change
`@@ -169,10 +169,10 @@ void Notification::NotificationDisplayed() {`
`169`	`169`	`}`
`170`	`170`
`171`	`171`	`void Notification::NotificationDestroyed() {`
`172`		`- Emit("close");`
`173`	`172`	`}`
`174`	`173`
`175`	`174`	`void Notification::NotificationClosed() {`
	`175`	`+ Emit("close");`
`176`	`176`	`}`
`177`	`177`
`178`	`178`	`// Showing notifications`