Write a warning instead of crashing.

CharlieHess · kevinsawicki · commit c213971a2dc8 · 2017-01-25T12:36:55.000-08:00
diff --git a/lib/browser/rpc-server.js b/lib/browser/rpc-server.js
@@ -160,6 +160,9 @@ const rendererMissingErrorMessage = (meta, args, callIntoRenderer) => {
 
   if (remoteEvents.length > 0) {
     message += `\nRemote event names: ${remoteEvents.join(', ')}`
+    remoteEvents.forEach((eventName) => {
+      sender.removeListener(eventName, callIntoRenderer)
+    })
   }
 
   return message
@@ -215,7 +218,7 @@ const unwrapArgs = function (sender, args) {
           if (!sender.isDestroyed() && webContentsId === sender.getId()) {
             sender.send('ELECTRON_RENDERER_CALLBACK', meta.id, valueToMeta(sender, args))
           } else {
-            throw new Error(rendererMissingErrorMessage(meta, args, callIntoRenderer))
+            console.warn(rendererMissingErrorMessage(meta, args, callIntoRenderer))
           }
         }
 
diff --git a/spec/api-ipc-spec.js b/spec/api-ipc-spec.js
@@ -495,7 +495,7 @@ describe('ipc module', function () {
       assert.equal(w.listenerCount('test'), 0)
     })
 
-    it('throws an error when a function is called in a destroyed renderer', (done) => {
+    it('shows a warning when a function is called in a destroyed renderer', (done) => {
       w = new BrowserWindow({
         show: false
       })
@@ -506,8 +506,8 @@ describe('ipc module', function () {
             'Function provided here: remote-event-handler.html:11:33',
             'Remote event names: remote-handler, other-remote-handler'
           ].join('\n')
-          const errorMessage = ipcRenderer.sendSync('try-emit-web-contents-event', w.webContents.id, 'remote-handler')
-          assert.equal(errorMessage, expectedMessage)
+          const warningMessage = ipcRenderer.sendSync('try-emit-web-contents-event', w.webContents.id, 'remote-handler')
+          assert.equal(warningMessage, expectedMessage)
           done()
         })
         w.webContents.reload()
diff --git a/spec/static/main.js b/spec/static/main.js
@@ -251,11 +251,13 @@ ipcMain.on('prevent-next-new-window', (event, id) => {
 })
 
 ipcMain.on('try-emit-web-contents-event', (event, id, eventName) => {
-  const contents = webContents.fromId(id)
-  try {
-    contents.emit(eventName, {sender: contents})
-    event.returnValue = null
-  } catch (error) {
-    event.returnValue = error.message
+  const consoleWarn = console.warn
+  let lastWarning = null
+  console.warn = (message) => {
+    lastWarning = message
   }
+  const contents = webContents.fromId(id)
+  contents.emit(eventName, {sender: contents})
+  event.returnValue = lastWarning
+  console.warn = consoleWarn
 })

Original file line number	Diff line number	Diff line change
`@@ -160,6 +160,9 @@ const rendererMissingErrorMessage = (meta, args, callIntoRenderer) => {`
`160`	`160`
`161`	`161`	`if (remoteEvents.length > 0) {`
`162`	`162`	message += `\nRemote event names: ${remoteEvents.join(', ')}`
	`163`	`+ remoteEvents.forEach((eventName) => {`
	`164`	`+ sender.removeListener(eventName, callIntoRenderer)`
	`165`	`+ })`
`163`	`166`	`}`
`164`	`167`
`165`	`168`	`return message`
`@@ -215,7 +218,7 @@ const unwrapArgs = function (sender, args) {`
`215`	`218`	`if (!sender.isDestroyed() && webContentsId === sender.getId()) {`
`216`	`219`	`sender.send('ELECTRON_RENDERER_CALLBACK', meta.id, valueToMeta(sender, args))`
`217`	`220`	`} else {`
`218`		`- throw new Error(rendererMissingErrorMessage(meta, args, callIntoRenderer))`
	`221`	`+ console.warn(rendererMissingErrorMessage(meta, args, callIntoRenderer))`
`219`	`222`	`}`
`220`	`223`	`}`
`221`	`224`