fix: avoid losing focus on inputs when opening menu (Windows/Linux) (electron#19707)

trop[bot] · codebytere · commit bac953292f98 · 2019-08-12T19:45:21.000-07:00
* remove cause of issue

* remove comment
diff --git a/atom/browser/ui/views/menu_bar.cc b/atom/browser/ui/views/menu_bar.cc
@@ -252,9 +252,6 @@ void MenuBar::OnMenuButtonClicked(views::MenuButton* source,
     return;
   }
 
-  GetFocusManager()->SetFocusedViewWithReason(
-      source, views::FocusManager::kReasonFocusTraversal);
-
   // Deleted in MenuDelegate::OnMenuClosed
   MenuDelegate* menu_delegate = new MenuDelegate(this);
   menu_delegate->RunMenu(menu_model_->GetSubmenuModelAt(id), source,

Original file line number	Diff line number	Diff line change
`@@ -252,9 +252,6 @@ void MenuBar::OnMenuButtonClicked(views::MenuButton* source,`
`252`	`252`	`return;`
`253`	`253`	`}`
`254`	`254`
`255`		`- GetFocusManager()->SetFocusedViewWithReason(`
`256`		`- source, views::FocusManager::kReasonFocusTraversal);`
`257`		`-`
`258`	`255`	`// Deleted in MenuDelegate::OnMenuClosed`
`259`	`256`	`MenuDelegate* menu_delegate = new MenuDelegate(this);`
`260`	`257`	`menu_delegate->RunMenu(menu_model_->GetSubmenuModelAt(id), source,`