chore: omit superceded Chromium updates from notes (electron#19400)

ckerr · codebytere · commit b3fb7497c29d · 2019-07-23T13:50:18.000-07:00
* feat: omit superceded Chromium updates from notes

* chore: simplify changed code
diff --git a/script/release/notes/notes.js b/script/release/notes/notes.js
@@ -591,6 +591,8 @@ const getNotes = async (fromRef, toRef, newVersion) => {
       })
   }
 
+  pool.commits = removeSupercededChromiumUpdates(pool.commits)
+
   const notes = {
     breaking: [],
     docs: [],
@@ -623,6 +625,20 @@ const getNotes = async (fromRef, toRef, newVersion) => {
   return notes
 }
 
+const removeSupercededChromiumUpdates = (commits) => {
+  const chromiumRegex = /^Updated Chromium to \d+\.\d+\.\d+\.\d+/
+  const updates = commits.filter(commit => (commit.note || commit.subject).match(chromiumRegex))
+  const keepers = commits.filter(commit => !updates.includes(commit))
+
+  // keep the newest update.
+  if (updates.length) {
+    updates.sort((a, b) => a.originalPr.number - b.originalPr.number)
+    keepers.push(updates.pop())
+  }
+
+  return keepers
+}
+
 /***
 ****  Render
 ***/
