chore: always try to nuke tags (electron#16452)

trop[bot] · codebytere · commit 95c73eebb206 · 2019-01-18T16:34:48.000-08:00
diff --git a/script/release-artifact-cleanup.js b/script/release-artifact-cleanup.js
@@ -102,6 +102,7 @@ async function cleanReleaseArtifacts () {
   if (releaseId) {
     if (isNightly) {
       const deletedNightlyDraft = await deleteDraft(releaseId, 'nightlies')
+
       // don't delete tag unless draft deleted successfully
       if (deletedNightlyDraft) {
         await Promise.all([
@@ -116,6 +117,11 @@ async function cleanReleaseArtifacts () {
         await deleteTag(args.tag, 'electron')
       }
     }
+  } else {
+    await Promise.all([
+      deleteTag(args.tag, 'electron'),
+      deleteTag(args.tag, 'nightlies')
+    ])
   }
 
   console.log(`${pass} failed release artifact cleanup complete`)

Original file line number	Diff line number	Diff line change
`@@ -102,6 +102,7 @@ async function cleanReleaseArtifacts () {`
`102`	`102`	`if (releaseId) {`
`103`	`103`	`if (isNightly) {`
`104`	`104`	`const deletedNightlyDraft = await deleteDraft(releaseId, 'nightlies')`
	`105`	`+`
`105`	`106`	`// don't delete tag unless draft deleted successfully`
`106`	`107`	`if (deletedNightlyDraft) {`
`107`	`108`	`await Promise.all([`
`@@ -116,6 +117,11 @@ async function cleanReleaseArtifacts () {`
`116`	`117`	`await deleteTag(args.tag, 'electron')`
`117`	`118`	`}`
`118`	`119`	`}`
	`120`	`+ } else {`
	`121`	`+ await Promise.all([`
	`122`	`+ deleteTag(args.tag, 'electron'),`
	`123`	`+ deleteTag(args.tag, 'nightlies')`
	`124`	`+ ])`
`119`	`125`	`}`
`120`	`126`
`121`	`127`	console.log(`${pass} failed release artifact cleanup complete`)