build: provide line numbers of bad patch lines when linting (electron#28666)

MarshallOfSound · web-flow · commit 9236e56ddced · 2021-04-15T10:43:35.000-07:00
diff --git a/script/lint.js b/script/lint.js
@@ -207,9 +207,9 @@ const LINTERS = [{
         console.warn(`Patch file '${f}' has no description. Every patch must contain a justification for why the patch exists and the plan for its removal.`);
         return false;
       }
-      const trailingWhitespace = patchText.split(/\r?\n/).some(line => line.startsWith('+') && /\s+$/.test(line));
-      if (trailingWhitespace) {
-        console.warn(`Patch file '${f}' has trailing whitespace on some lines.`);
+      const trailingWhitespaceLines = patchText.split(/\r?\n/).map((line, index) => [line, index]).filter(([line]) => line.startsWith('+') && /\s+$/.test(line)).map(([, lineNumber]) => lineNumber + 1);
+      if (trailingWhitespaceLines.length > 0) {
+        console.warn(`Patch file '${f}' has trailing whitespace on some lines (${trailingWhitespaceLines.join(',')}).`);
         return false;
       }
       return true;

Original file line number	Diff line number	Diff line change
`@@ -207,9 +207,9 @@ const LINTERS = [{`
`207`	`207`	console.warn(`Patch file '${f}' has no description. Every patch must contain a justification for why the patch exists and the plan for its removal.`);
`208`	`208`	`return false;`
`209`	`209`	`}`
`210`		`- const trailingWhitespace = patchText.split(/\r?\n/).some(line => line.startsWith('+') && /\s+$/.test(line));`
`211`		`- if (trailingWhitespace) {`
`212`		- console.warn(`Patch file '${f}' has trailing whitespace on some lines.`);
	`210`	`+ const trailingWhitespaceLines = patchText.split(/\r?\n/).map((line, index) => [line, index]).filter(([line]) => line.startsWith('+') && /\s+$/.test(line)).map(([, lineNumber]) => lineNumber + 1);`
	`211`	`+ if (trailingWhitespaceLines.length > 0) {`
	`212`	+ console.warn(`Patch file '${f}' has trailing whitespace on some lines (${trailingWhitespaceLines.join(',')}).`);
`213`	`213`	`return false;`
`214`	`214`	`}`
`215`	`215`	`return true;`