Emit a close event

MarshallOfSound · MarshallOfSound · commit 6cdfb43e4e28 · 2017-05-29T21:33:43.000+10:00
diff --git a/atom/browser/api/atom_api_notification.cc b/atom/browser/api/atom_api_notification.cc
@@ -126,6 +126,10 @@ void Notification::OnShown() {
   Emit("show");
 }
 
+void Notification::OnClosed() {
+  Emit("close");
+}
+
 void Notification::NotifyPropsUpdated() {}
 
 // Showing notifications
diff --git a/atom/browser/api/atom_api_notification.h b/atom/browser/api/atom_api_notification.h
@@ -35,6 +35,7 @@ class Notification : public mate::TrackableObject<Notification>,
   void OnClicked() override;
   void OnReplied(std::string reply) override;
   void OnShown() override;
+  void OnClosed() override;
 
  protected:
   Notification(v8::Isolate* isolate,
diff --git a/atom/browser/ui/notification_delegate_adapter.cc b/atom/browser/ui/notification_delegate_adapter.cc
@@ -23,7 +23,9 @@ void AtomNotificationDelegateAdapter::NotificationClick() {
 void AtomNotificationDelegateAdapter::NotificationReplied(std::string reply) {
   observer_->OnReplied(reply);
 }
-void AtomNotificationDelegateAdapter::NotificationDestroyed() {}
+void AtomNotificationDelegateAdapter::NotificationDestroyed() {
+  observer_->OnClosed();
+}
 void AtomNotificationDelegateAdapter::NotificationFailed() {}
 
 }  // namespace atom
diff --git a/atom/browser/ui/notification_observer.h b/atom/browser/ui/notification_observer.h
@@ -14,6 +14,7 @@ class NotifictionObserver {
   virtual void OnClicked() {}
   virtual void OnReplied(std::string reply) {}
   virtual void OnShown() {}
+  virtual void OnClosed() {}
 
  protected:
   virtual ~NotifictionObserver() {}
diff --git a/docs/api/notification.md b/docs/api/notification.md
@@ -37,32 +37,34 @@ Objects created with `new Notification` emit the following events:
 **Note:** Some events are only available on specific operating systems and are
 labeled as such.
 
-#### Event: 'click'
+#### Event: 'show'
 
 Returns:
 
 * `event` Event
 
-Emitted when the document changed its title, calling `event.preventDefault()`
-will prevent the native window's title from changing.
+Emitted when the notification is shown to the user, note this could be fired
+multiple times as a notification can be shown multiple times through the
+`show()` method.
 
-#### Event: 'close'
+#### Event: 'click'
 
 Returns:
 
 * `event` Event
 
-Emitted when the notification is shown to the user, note this could be fired
-multiple times as a notification can be shown multiple times through the
-`show()` method.
+Emitted when the notification is clicked by the user.
 
-#### Event: 'click'
+#### Event: 'close'
 
 Returns:
 
 * `event` Event
 
-Emitted when the notification is clicked by the user.
+Emitted when the notification is closed by manual intervention from the user.
+
+This event is not guarunteed to be emitted in all cases where the notification
+is closed.
 
 #### Event: 'reply' _macOS_
 

Original file line number	Diff line number	Diff line change
`@@ -126,6 +126,10 @@ void Notification::OnShown() {`
`126`	`126`	`Emit("show");`
`127`	`127`	`}`
`128`	`128`
	`129`	`+void Notification::OnClosed() {`
	`130`	`+ Emit("close");`
	`131`	`+}`
	`132`	`+`
`129`	`133`	`void Notification::NotifyPropsUpdated() {}`
`130`	`134`
`131`	`135`	`// Showing notifications`