Skip to content

Commit 5fe9f28

Browse files
committed
Only generate node.lib when we need to upload node headers.
1 parent 766347f commit 5fe9f28

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

script/build.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ def main():
2020
args = parse_args()
2121
for config in args.configuration:
2222
build_path = os.path.join('out', config)
23-
subprocess.call([ninja, '-C', build_path])
23+
subprocess.call([ninja, '-C', build_path, args.target])
2424

2525

2626
def parse_args():
@@ -30,6 +30,10 @@ def parse_args():
3030
nargs='+',
3131
default=CONFIGURATIONS,
3232
required=False)
33+
parser.add_argument('-t', '--target',
34+
help='Build specified target',
35+
default='atom',
36+
required=False)
3337
return parser.parse_args()
3438

3539

script/upload.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,17 @@ def dist_newer_than_head():
6464
def upload(bucket, access_key, secret_key, version=ATOM_SHELL_VRESION):
6565
os.chdir(DIST_DIR)
6666

67-
# s3put(bucket, access_key, secret_key, DIST_DIR,
68-
# 'atom-shell/{0}'.format(version), [DIST_NAME])
67+
s3put(bucket, access_key, secret_key, DIST_DIR,
68+
'atom-shell/{0}'.format(version), [DIST_NAME])
6969
s3put(bucket, access_key, secret_key, DIST_DIR,
7070
'atom-shell/dist/{0}'.format(NODE_VERSION), glob.glob('node-*.tar.gz'))
7171

7272
if TARGET_PLATFORM == 'win32':
73+
# Generate the node.lib.
74+
build = os.path.join(SOURCE_ROOT, 'script', 'build.py')
75+
subprocess.check_call([sys.executable, build, '-c', 'Release',
76+
'-t', 'generate_node_lib'])
77+
7378
out_dir = os.path.join(SOURCE_ROOT, 'out', 'Release')
7479
node_lib = os.path.join(out_dir, 'node.lib')
7580
s3put(bucket, access_key, secret_key, out_dir,

0 commit comments

Comments
 (0)