test: disable flaky arm tests (electron#26046)

jkleinsc · web-flow · commit 4ce7ca6cfb28 · 2020-10-19T20:11:30.000-04:00
* tests: disable flaking test on all arm platforms

* tests: disable flaky did-change-theme-color tests on WOA
diff --git a/spec-main/api-service-workers-spec.ts b/spec-main/api-service-workers-spec.ts
@@ -7,6 +7,7 @@ import { v4 } from 'uuid';
 import { AddressInfo } from 'net';
 import { closeWindow } from './window-helpers';
 import { emittedOnce, emittedNTimes } from './events-helpers';
+import { ifdescribe } from './spec-helpers';
 
 const partition = 'service-workers-spec';
 const uuid = v4();
@@ -65,7 +66,8 @@ describe('session.serviceWorkers', () => {
     });
   });
 
-  describe('getFromVersionID()', () => {
+  // TODO (jkleinsc) - reenable this test once https://github.com/electron/electron/issues/26043 is resolved
+  ifdescribe(!process.arch.includes('arm'))('getFromVersionID()', () => {
     it('should report the correct script url and scope', async () => {
       const eventInfo = await emittedOnce(ses.serviceWorkers, 'console-message', () => w.loadURL(`${baseUrl}/index.html`));
       const details: Electron.MessageDetails = eventInfo[1];
diff --git a/spec-main/api-web-contents-spec.ts b/spec-main/api-web-contents-spec.ts
@@ -1375,7 +1375,8 @@ describe('webContents module', () => {
     }
   });
 
-  describe('did-change-theme-color event', () => {
+  // TODO (jkleinsc) - reenable this test on WOA once https://github.com/electron/electron/issues/26045 is resolved
+  ifdescribe(process.platform !== 'win32' || process.arch !== 'arm64')('did-change-theme-color event', () => {
     afterEach(closeAllWindows);
     it('is triggered with correct theme color', (done) => {
       const w = new BrowserWindow({ show: true });
diff --git a/spec/webview-spec.js b/spec/webview-spec.js
@@ -986,7 +986,8 @@ describe('<webview> tag', function () {
     });
   });
 
-  describe('did-change-theme-color event', () => {
+  // TODO (jkleinsc) - reenable this test on WOA once https://github.com/electron/electron/issues/26045 is resolved
+  ifdescribe(process.platform !== 'win32' || process.arch !== 'arm64')('did-change-theme-color event', () => {
     it('emits when theme color changes', async () => {
       loadWebView(webview, {
         src: `file://${fixtures}/pages/theme-color.html`

Original file line number	Diff line number	Diff line change
`@@ -1375,7 +1375,8 @@ describe('webContents module', () => {`
`1375`	`1375`	`}`
`1376`	`1376`	`});`
`1377`	`1377`
`1378`		`- describe('did-change-theme-color event', () => {`
	`1378`	`+ // TODO (jkleinsc) - reenable this test on WOA once https://github.com/electron/electron/issues/26045 is resolved`
	`1379`	`+ ifdescribe(process.platform !== 'win32' \|\| process.arch !== 'arm64')('did-change-theme-color event', () => {`
`1379`	`1380`	`afterEach(closeAllWindows);`
`1380`	`1381`	`it('is triggered with correct theme color', (done) => {`
`1381`	`1382`	`const w = new BrowserWindow({ show: true });`