fix: restore accessibility window title on macOS (electron#21465)

trop[bot] · codebytere · commit 42b4433fe48b · 2019-12-10T21:05:04.000-05:00
Electron's `AtomNSWindow` implements `accessibilityAttributeValue` to
provide various accessibility info to the OS, including window titles.

Chromium 75 changed to Apple's newer accessibility API for window titles
in the super class that `AtomNSWindow` inherits from. macOS still
supports both the old and new style APIs, but it will prefer the new
style if it is implemented.  This means the Electron window title is
being ignored because the newer API at the Chromium level has taken
precedence.

By implementing the newer accessibility API in `AtomNSWindow`, this
restores correct accessibility window titles in macOS Electron apps.

This is a regression has been present since Electron 6.0.0 (the first
release including the Chromium change above).
diff --git a/atom/browser/ui/cocoa/atom_ns_window.mm b/atom/browser/ui/cocoa/atom_ns_window.mm
@@ -99,8 +99,6 @@ - (void)setFrame:(NSRect)windowFrame display:(BOOL)displayViews {
 }
 
 - (id)accessibilityAttributeValue:(NSString*)attribute {
-  if ([attribute isEqual:NSAccessibilityTitleAttribute])
-    return base::SysUTF8ToNSString(shell_->GetTitle());
   if ([attribute isEqual:NSAccessibilityEnabledAttribute])
     return [NSNumber numberWithBool:YES];
   if (![attribute isEqualToString:@"AXChildren"])
@@ -121,6 +119,10 @@ - (id)accessibilityAttributeValue:(NSString*)attribute {
   return [children filteredArrayUsingPredicate:predicate];
 }
 
+- (NSString*)accessibilityTitle {
+  return base::SysUTF8ToNSString(shell_->GetTitle());
+}
+
 - (BOOL)canBecomeMainWindow {
   return !self.disableKeyOrMainWindow;
 }

Original file line number	Diff line number	Diff line change
`@@ -99,8 +99,6 @@ - (void)setFrame:(NSRect)windowFrame display:(BOOL)displayViews {`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`- (id)accessibilityAttributeValue:(NSString*)attribute {`
`102`		`- if ([attribute isEqual:NSAccessibilityTitleAttribute])`
`103`		`- return base::SysUTF8ToNSString(shell_->GetTitle());`
`104`	`102`	`if ([attribute isEqual:NSAccessibilityEnabledAttribute])`
`105`	`103`	`return [NSNumber numberWithBool:YES];`
`106`	`104`	`if (![attribute isEqualToString:@"AXChildren"])`
`@@ -121,6 +119,10 @@ - (id)accessibilityAttributeValue:(NSString*)attribute {`
`121`	`119`	`return [children filteredArrayUsingPredicate:predicate];`
`122`	`120`	`}`
`123`	`121`
	`122`	`+- (NSString*)accessibilityTitle {`
	`123`	`+ return base::SysUTF8ToNSString(shell_->GetTitle());`
	`124`	`+}`
	`125`	`+`
`124`	`126`	`- (BOOL)canBecomeMainWindow {`
`125`	`127`	`return !self.disableKeyOrMainWindow;`
`126`	`128`	`}`