Merge pull request adamlaska#8 from electron/set-read-only

zcbenz · web-flow · commit 400d6c3de5df · 2017-01-16T06:53:42.000+09:00
Support setting read-only property value
diff --git a/native_mate/dictionary.h b/native_mate/dictionary.h
@@ -93,6 +93,19 @@ class Dictionary {
     return !result.IsNothing() && result.FromJust();
   }
 
+  template<typename T>
+  bool SetReadOnly(const base::StringPiece& key, T val) {
+    v8::Local<v8::Value> v8_value;
+    if (!TryConvertToV8(isolate_, val, &v8_value))
+      return false;
+    v8::Maybe<bool> result =
+        GetHandle()->DefineOwnProperty(isolate_->GetCurrentContext(),
+                                       StringToV8(isolate_, key),
+                                       v8_value,
+                                       v8::ReadOnly);
+    return !result.IsNothing() && result.FromJust();
+  }
+
   template<typename T>
   bool SetMethod(const base::StringPiece& key, const T& callback) {
     return GetHandle()->Set(
