feat: add exit code to render-process-gone details (electron#27580)

nornagon · web-flow · commit 28599e5e7cf4 · 2021-02-08T17:08:11.000-08:00
diff --git a/docs/api/app.md b/docs/api/app.md
@@ -406,6 +406,9 @@ Returns:
     * `oom` - Process ran out of memory
     * `launch-failed` - Process never successfully launched
     * `integrity-failure` - Windows code integrity checks failed
+  * `exitCode` Integer - The exit code of the process, unless `reason` is
+    `launch-failed`, in which case `exitCode` will be a platform-specific
+    launch failure error code.
 
 Emitted when the renderer process unexpectedly disappears.  This is normally
 because it was crashed or killed.
diff --git a/docs/api/web-contents.md b/docs/api/web-contents.md
@@ -403,6 +403,9 @@ Returns:
     * `oom` - Process ran out of memory
     * `launch-failed` - Process never successfully launched
     * `integrity-failure` - Windows code integrity checks failed
+  * `exitCode` Integer - The exit code of the process, unless `reason` is
+    `launch-failed`, in which case `exitCode` will be a platform-specific
+    launch failure error code.
 
 Emitted when the renderer process unexpectedly disappears.  This is normally
 because it was crashed or killed.
diff --git a/shell/browser/api/electron_api_web_contents.cc b/shell/browser/api/electron_api_web_contents.cc
@@ -1396,6 +1396,7 @@ void WebContents::RenderProcessGone(base::TerminationStatus status) {
   v8::HandleScope handle_scope(isolate);
   gin_helper::Dictionary details = gin_helper::Dictionary::CreateEmpty(isolate);
   details.Set("reason", status);
+  details.Set("exitCode", web_contents()->GetCrashedErrorCode());
   Emit("render-process-gone", details);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1396,6 +1396,7 @@ void WebContents::RenderProcessGone(base::TerminationStatus status) {`
`1396`	`1396`	`v8::HandleScope handle_scope(isolate);`
`1397`	`1397`	`gin_helper::Dictionary details = gin_helper::Dictionary::CreateEmpty(isolate);`
`1398`	`1398`	`details.Set("reason", status);`
	`1399`	`+ details.Set("exitCode", web_contents()->GetCrashedErrorCode());`
`1399`	`1400`	`Emit("render-process-gone", details);`
`1400`	`1401`	`}`
`1401`	`1402`