Replace "size()" with "empty()".

hokein · hokein · commit 00693ba07550 · 2017-03-30T21:59:18.000+02:00
diff --git a/atom/app/atom_content_client.cc b/atom/app/atom_content_client.cc
@@ -44,7 +44,7 @@ content::PepperPluginInfo CreatePepperFlashInfo(const base::FilePath& path,
 
   std::vector<std::string> flash_version_numbers = base::SplitString(
       version, ".", base::TRIM_WHITESPACE, base::SPLIT_WANT_NONEMPTY);
-  if (flash_version_numbers.size() < 1)
+  if (flash_version_numbers.empty())
     flash_version_numbers.push_back("11");
   // |SplitString()| puts in an empty string given an empty string. :(
   else if (flash_version_numbers[0].empty())
diff --git a/atom/browser/api/atom_api_app.cc b/atom/browser/api/atom_api_app.cc
@@ -427,7 +427,7 @@ void OnClientCertificateSelected(
 
   auto certs = net::X509Certificate::CreateCertificateListFromBytes(
       data.c_str(), data.length(), net::X509Certificate::FORMAT_AUTO);
-  if (certs.size() > 0)
+  if (!certs.empty())
     delegate->ContinueWithCertificate(certs[0].get());
 }
 
diff --git a/atom/browser/api/atom_api_auto_updater.cc b/atom/browser/api/atom_api_auto_updater.cc
@@ -88,7 +88,7 @@ void AutoUpdater::SetFeedURL(const std::string& url, mate::Arguments* args) {
 void AutoUpdater::QuitAndInstall() {
   // If we don't have any window then quitAndInstall immediately.
   WindowList* window_list = WindowList::GetInstance();
-  if (window_list->size() == 0) {
+  if (window_list->empty()) {
     auto_updater::AutoUpdater::QuitAndInstall();
     return;
   }
diff --git a/atom/browser/browser.cc b/atom/browser/browser.cc
@@ -44,7 +44,7 @@ void Browser::Quit() {
     return;
 
   atom::WindowList* window_list = atom::WindowList::GetInstance();
-  if (window_list->size() == 0)
+  if (window_list->empty())
     NotifyAndShutdown();
 
   window_list->CloseAllWindows();
@@ -66,7 +66,7 @@ void Browser::Exit(mate::Arguments* args) {
 
     // Must destroy windows before quitting, otherwise bad things can happen.
     atom::WindowList* window_list = atom::WindowList::GetInstance();
-    if (window_list->size() == 0) {
+    if (window_list->empty()) {
       Shutdown();
     } else {
       // Unlike Quit(), we do not ask to close window, but destroy the window
diff --git a/atom/browser/node_debugger.cc b/atom/browser/node_debugger.cc
@@ -164,7 +164,7 @@ void NodeDebugger::DidRead(net::test_server::StreamListenSocket* socket,
   buffer_.append(data, len);
 
   do {
-    if (buffer_.size() == 0)
+    if (buffer_.empty())
       return;
 
     // Read the "Content-Length" header.
diff --git a/atom/browser/ui/cocoa/atom_touch_bar.mm b/atom/browser/ui/cocoa/atom_touch_bar.mm
@@ -319,7 +319,7 @@ - (NSTouchBarItem*)makeColorPickerForID:(NSString*)id
 - (void)updateColorPicker:(NSColorPickerTouchBarItem*)item
              withSettings:(const mate::PersistentDictionary&)settings {
   std::vector<std::string> colors;
-  if (settings.Get("availableColors", &colors) && colors.size() > 0) {
+  if (settings.Get("availableColors", &colors) && !colors.empty()) {
     NSColorList* color_list  = [[[NSColorList alloc] initWithName:@""] autorelease];
     for (size_t i = 0; i < colors.size(); ++i) {
       [color_list insertColor:[self colorFromHexColorString:colors[i]]
diff --git a/atom/browser/window_list.cc b/atom/browser/window_list.cc
@@ -46,7 +46,7 @@ void WindowList::RemoveWindow(NativeWindow* window) {
   for (WindowListObserver& observer : observers_.Get())
     observer.OnWindowRemoved(window);
 
-  if (windows.size() == 0) {
+  if (windows.empty()) {
     for (WindowListObserver& observer : observers_.Get())
       observer.OnWindowAllClosed();
   }

Original file line number	Diff line number	Diff line change
`@@ -427,7 +427,7 @@ void OnClientCertificateSelected(`
`427`	`427`
`428`	`428`	`auto certs = net::X509Certificate::CreateCertificateListFromBytes(`
`429`	`429`	`data.c_str(), data.length(), net::X509Certificate::FORMAT_AUTO);`
`430`		`- if (certs.size() > 0)`
	`430`	`+ if (!certs.empty())`
`431`	`431`	`delegate->ContinueWithCertificate(certs[0].get());`
`432`	`432`	`}`
`433`	`433`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ void AutoUpdater::SetFeedURL(const std::string& url, mate::Arguments* args) {`
`88`	`88`	`void AutoUpdater::QuitAndInstall() {`
`89`	`89`	`// If we don't have any window then quitAndInstall immediately.`
`90`	`90`	`WindowList* window_list = WindowList::GetInstance();`
`91`		`- if (window_list->size() == 0) {`
	`91`	`+ if (window_list->empty()) {`
`92`	`92`	`auto_updater::AutoUpdater::QuitAndInstall();`
`93`	`93`	`return;`
`94`	`94`	`}`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ void WindowList::RemoveWindow(NativeWindow* window) {`
`46`	`46`	`for (WindowListObserver& observer : observers_.Get())`
`47`	`47`	`observer.OnWindowRemoved(window);`
`48`	`48`
`49`		`- if (windows.size() == 0) {`
	`49`	`+ if (windows.empty()) {`
`50`	`50`	`for (WindowListObserver& observer : observers_.Get())`
`51`	`51`	`observer.OnWindowAllClosed();`
`52`	`52`	`}`