Merged in [17085] from sasha@dashcare.nl:

levkowetz · levkowetz · commit fc0060079a77 · 2019-11-27T22:19:58.000Z
Fix ietf-tools#2278 - Notify secretary when a review request is closed. The assigned reviewer was already notified, but secretaries were always excluded. - Legacy-Id: 17108 Note: SVN reference [17085] has been migrated to Git commit 56003f6
diff --git a/ietf/doc/tests_review.py b/ietf/doc/tests_review.py
@@ -189,6 +189,7 @@ def test_close_request(self):
         review_team = ReviewTeamFactory(acronym="reviewteam", name="Review Team", type_id="review", list_email="reviewteam@ietf.org", parent=Group.objects.get(acronym="farfut"))
         rev_role = RoleFactory(group=review_team,person__user__username='reviewer',person__user__email='reviewer@example.com',name_id='reviewer')
         RoleFactory(group=review_team,person__user__username='reviewsecretary',person__user__email='reviewsecretary@example.com',name_id='secr')
+        RoleFactory(group=review_team,person__user__username='reviewsecretary2',person__user__email='reviewsecretary2@example.com',name_id='secr')
         review_req = ReviewRequestFactory(doc=doc,team=review_team,type_id='early',state_id='assigned',requested_by=rev_role.person,deadline=datetime.datetime.now()+datetime.timedelta(days=20))
         ReviewAssignmentFactory(review_request=review_req, state_id='accepted', reviewer=rev_role.person.email_set.first())
 
@@ -229,6 +230,7 @@ def test_close_request(self):
         self.assertEqual(len(outbox), 1)
         self.assertIn('<reviewer@example.com>', outbox[0]["To"])
         self.assertNotIn("<reviewsecretary@example.com>", outbox[0]["To"])
+        self.assertIn("<reviewsecretary2@example.com>", outbox[0]["CC"])
         mail_content = outbox[0].get_payload(decode=True).decode("utf-8").lower()
         self.assertIn("closed", mail_content)
         self.assertIn("review_request_close_comment", mail_content)
diff --git a/ietf/review/utils.py b/ietf/review/utils.py
@@ -570,7 +570,7 @@ def close_review_request(request, review_req, close_state, close_comment=''):
         email_review_request_change(
             request, review_req,
             "Closed review request for {}: {}".format(review_req.doc.name, close_state.name),
-            msg=msg, by=request.user.person, notify_secretary=False,
+            msg=msg, by=request.user.person, notify_secretary=True,
             notify_reviewer=True, notify_requested_by=True)
 
 def suggested_review_requests_for_team(team):
