Skip to content

Commit d3468f4

Browse files
committed
Add some refinements for the admin interface. Show contact link and coloured Login/User links to show broken entries.
- Legacy-Id: 2907
1 parent 3418e10 commit d3468f4

File tree

2 files changed

+33
-19
lines changed

2 files changed

+33
-19
lines changed

ietf/liaisons/admin.py

Lines changed: 26 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,12 @@
1313

1414
from ietf.liaisons.models import (FromBodies, LiaisonDetail, LiaisonPurpose,
1515
SDOs, LiaisonManagers, SDOAuthorizedIndividual)
16+
from ietf.ietfauth.models import LegacyWgPassword, LegacyLiaisonUser
1617

1718

1819
class FromBodiesAdmin(admin.ModelAdmin):
19-
pass
20+
list_display = ['body_name', 'contact_link', 'other_sdo']
21+
admin.site.register(FromBodies, FromBodiesAdmin)
2022

2123

2224
class LiaisonDetailAdmin(admin.ModelAdmin):
@@ -26,32 +28,29 @@ class LiaisonDetailAdmin(admin.ModelAdmin):
2628
# 'response_contact', 'technical_contact', 'purpose', 'purpose_text', 'deadline_date', 'action_taken',
2729
# 'related_to')
2830
raw_id_fields=['person', 'related_to']
31+
admin.site.register(LiaisonDetail, LiaisonDetailAdmin)
32+
2933

3034
class LiaisonPurposeAdmin(admin.ModelAdmin):
3135
ordering = ('purpose_text', )
32-
33-
34-
class LiaisonManagersInline(admin.TabularInline):
35-
model = LiaisonManagers
36-
raw_id_fields=['person']
37-
38-
39-
class SDOAuthorizedIndividualInline(admin.TabularInline):
40-
model = SDOAuthorizedIndividual
41-
raw_id_fields=['person']
36+
admin.site.register(LiaisonPurpose, LiaisonPurposeAdmin)
4237

4338

4439
class LiaisonManagersAdmin(admin.ModelAdmin):
4540
list_display = ['id', '__unicode__', 'person_link', 'user_name', 'groups', 'sdo_link', ]
4641
ordering = ('person__first_name', 'person__last_name' )
4742
# fields = ('person', 'sdo')
4843
raw_id_fields=['person']
44+
admin.site.register(LiaisonManagers, LiaisonManagersAdmin)
4945

5046

51-
class SDOAuthorizedIndividualAdmin(admin.ModelAdmin):
52-
list_display = ['id', 'person_link', 'user_name', 'groups', 'sdo_link']
47+
class LiaisonManagersInline(admin.TabularInline):
48+
model = LiaisonManagers
5349
raw_id_fields=['person']
5450

51+
class SDOAuthorizedIndividualInline(admin.TabularInline):
52+
model = SDOAuthorizedIndividual
53+
raw_id_fields=['person']
5554

5655
class SDOsAdmin(admin.ModelAdmin):
5756
list_display = ['sdo_id', 'sdo_name', 'liaisonmanager_link', 'sdo_contact_link']
@@ -117,11 +116,20 @@ def send_one_reminder(self, request, object_id):
117116
raise Http404(_('%(name)s object with primary key %(key)r does not exist.') % {'name': force_unicode(opts.verbose_name), 'key': escape(object_id)})
118117

119118
return self.send_reminder(request, sdo=obj)
119+
admin.site.register(SDOs, SDOsAdmin)
120120

121121

122-
#admin.site.register(FromBodies, FromBodiesAdmin)
123-
admin.site.register(LiaisonDetail, LiaisonDetailAdmin)
124-
admin.site.register(LiaisonPurpose, LiaisonPurposeAdmin)
125-
admin.site.register(SDOs, SDOsAdmin)
126-
admin.site.register(LiaisonManagers, LiaisonManagersAdmin)
122+
class SDOAuthorizedIndividualAdmin(admin.ModelAdmin):
123+
list_display = ['id', 'person_link', 'user_name', 'groups', 'sdo_link']
124+
raw_id_fields=['person']
127125
admin.site.register(SDOAuthorizedIndividual, SDOAuthorizedIndividualAdmin)
126+
127+
128+
class LegacyWgPasswordAdmin(admin.ModelAdmin):
129+
list_display = ['pk', 'person_link', 'login_name', ]
130+
admin.site.register(LegacyWgPassword, LegacyWgPasswordAdmin)
131+
132+
133+
class LegacyLiaisonUserAdmin(admin.ModelAdmin):
134+
list_display = ['pk', 'person_link', 'login_name', 'user_level', 'comment', ]
135+
admin.site.register(LegacyLiaisonUser, LegacyLiaisonUserAdmin)

ietf/liaisons/models.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ class Meta:
3131
db_table = 'from_bodies'
3232
verbose_name = "From body"
3333
verbose_name_plural = "From bodies"
34+
contact_link = admin_link('poc', label='Contact')
35+
3436

3537

3638
class OutgoingLiaisonApproval(models.Model):
@@ -237,7 +239,11 @@ def user_name(self):
237239
if user:
238240
return u'<a href="/admin/auth/user/%s/">%s</a>' % (user.id, login_name)
239241
else:
240-
return u'<a href="/admin/auth/user/"><span style="color: red">%s</span></a>' % (login_name)
242+
if login_name:
243+
return u'Add login: <a href="/admin/auth/user/add/?username=%s"><span style="color: red">%s</span></a>' % (login_name, login_name)
244+
else:
245+
return u'Add liaison user: <a href="/admin/ietfauth/legacyliaisonuser/add/?person=%s&login_name=%s&user_level=3"><span style="color: red">%s</span></a>' % (self.person.pk, self.person.email()[1], self.person, )
246+
241247
user_name.allow_tags = True
242248
def groups(self):
243249
user, login_name = self.user()

0 commit comments

Comments
 (0)