Skip to content

Commit cfcefc2

Browse files
levkowetzlevkowetz
committed
Merged in [16144] from housley@vigilsec.com:
 Remove some clutter from I-D upload page. The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes ietf-tools#2057. - Legacy-Id: 16151 Note: SVN reference [16144] has been migrated to Git commit 37851b9
3 parents 255a815 + 37851b9 + 6dc25ca commit cfcefc2

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+2094
-1028
lines changed

‎ietf/bin/send-review-reminders‎

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,19 @@ django.setup()
1919

2020
import datetime
2121
from ietf.review.utils import (
22-
review_requests_needing_reviewer_reminder, email_reviewer_reminder,
23-
review_requests_needing_secretary_reminder, email_secretary_reminder,
22+
review_assignments_needing_reviewer_reminder, email_reviewer_reminder,
23+
review_assignments_needing_secretary_reminder, email_secretary_reminder,
2424
)
2525

2626
today = datetime.date.today()
2727

28-
for review_req in review_requests_needing_reviewer_reminder(today):
29-
email_reviewer_reminder(review_req)
30-
print("Emailed reminder to {} for review of {} in {} (req. id {})".format(review_req.reviewer.address, review_req.doc_id, review_req.team.acronym, review_req.pk))
28+
for assignment in review_assignments_needing_reviewer_reminder(today):
29+
email_reviewer_reminder(assignment.review_request)
30+
for review_assignment in assignments.review_req.reviewassignment_set.all():
31+
print("Emailed reminder to {} for review of {} in {} (req. id {})".format(review_assignment.reviewer.address, assignment.review_req.doc_id, assignment.review_req.team.acronym, assignment.review_req.pk))
3132

32-
for review_req, secretary_role in review_requests_needing_secretary_reminder(today):
33-
email_secretary_reminder(review_req, secretary_role)
34-
print("Emailed reminder to {} for review of {} in {} (req. id {})".format(review_req.secretary_role.email.address, review_req.doc_id, review_req.team.acronym, review_req.pk))
33+
for assignment, secretary_role in review_assignments_needing_secretary_reminder(today):
34+
email_secretary_reminder(assignment.review_request, secretary_role)
35+
review_req = assignment.review_request
36+
print("Emailed reminder to {} for review of {} in {} (req. id {})".format(secretary_role.email.address, review_req.doc_id, review_req.team.acronym, review_req.pk))
3537

‎ietf/dbtemplate/migrations/0003_adjust_review_templates.py‎

Lines changed: 118 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,118 @@
1+
# -*- coding: utf-8 -*-
2+
# Generated by Django 1.11.20 on 2019-03-05 11:39
3+
from __future__ import unicode_literals
4+
5+
from django.db import migrations
6+
7+
def forward(apps, schema_editor):
8+
DBTemplate = apps.get_model('dbtemplate', 'DBTemplate')
9+
DBTemplate.objects.filter(id=186).update(content="""I am the assigned Gen-ART reviewer for this draft. The General Area
10+
Review Team (Gen-ART) reviews all IETF documents being processed
11+
by the IESG for the IETF Chair. Please treat these comments just
12+
like any other last call comments.
13+
14+
For more information, please see the FAQ at
15+
16+
<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
17+
18+
Document: {{ assignment.review_request.doc.name }}-??
19+
Reviewer: {{ assignment.reviewer.person.plain_name }}
20+
Review Date: {{ today }}
21+
IETF LC End Date: {% if assignment.review_request.doc.most_recent_ietflc %}{{ assignment.review_request.doc.most_recent_ietflc.expires|date:"Y-m-d" }}{% else %}None{% endif %}
22+
IESG Telechat date: {{ assignment.review_request.doc.telechat_date|default:'Not scheduled for a telechat' }}
23+
24+
Summary:
25+
26+
Major issues:
27+
28+
Minor issues:
29+
30+
Nits/editorial comments:
31+
""")
32+
33+
DBTemplate.objects.filter(id=187).update(content="""I am the assigned Gen-ART reviewer for this draft. The General Area
34+
Review Team (Gen-ART) reviews all IETF documents being processed
35+
by the IESG for the IETF Chair. Please wait for direction from your
36+
document shepherd or AD before posting a new version of the draft.
37+
38+
For more information, please see the FAQ at
39+
40+
<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
41+
42+
Document: {{ assignment.review_request.doc.name }}-??
43+
Reviewer: {{ assignment.reviewer.person.plain_name }}
44+
Review Date: {{ today }}
45+
IETF LC End Date: {% if assignment.review_req.doc.most_recent_ietflc %}{{ assignment.review_request.doc.most_recent_ietflc.expires|date:"Y-m-d" }}{% else %}None{% endif %}
46+
IESG Telechat date: {{ assignment.review_request.doc.telechat_date|default:'Not scheduled for a telechat' }}
47+
48+
Summary:
49+
50+
Major issues:
51+
52+
Minor issues:
53+
54+
Nits/editorial comments:
55+
56+
""")
57+
58+
def reverse(apps, schema_editor):
59+
DBTemplate = apps.get_model('dbtemplate','DBTemplate')
60+
DBTemplate.objects.filter(id=186).update(content="""I am the assigned Gen-ART reviewer for this draft. The General Area
61+
Review Team (Gen-ART) reviews all IETF documents being processed
62+
by the IESG for the IETF Chair. Please treat these comments just
63+
like any other last call comments.
64+
65+
For more information, please see the FAQ at
66+
67+
<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
68+
69+
Document: {{ review_req.doc.name }}-??
70+
Reviewer: {{ review_req.reviewer.person.plain_name }}
71+
Review Date: {{ today }}
72+
IETF LC End Date: {% if review_req.doc.most_recent_ietflc %}{{ review_req.doc.most_recent_ietflc.expires|date:"Y-m-d" }}{% else %}None{% endif %}
73+
IESG Telechat date: {{ review_req.doc.telechat_date|default:'Not scheduled for a telechat' }}
74+
75+
Summary:
76+
77+
Major issues:
78+
79+
Minor issues:
80+
81+
Nits/editorial comments:
82+
83+
""")
84+
DBTemplate.objects.filter(id=187).update(content="""I am the assigned Gen-ART reviewer for this draft. The General Area
85+
Review Team (Gen-ART) reviews all IETF documents being processed
86+
by the IESG for the IETF Chair. Please wait for direction from your
87+
document shepherd or AD before posting a new version of the draft.
88+
89+
For more information, please see the FAQ at
90+
91+
<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
92+
93+
Document: {{ review_req.doc.name }}-??
94+
Reviewer: {{ review_req.reviewer.person.plain_name }}
95+
Review Date: {{ today }}
96+
IETF LC End Date: {% if review_req.doc.most_recent_ietflc %}{{ review_req.doc.most_recent_ietflc.expires|date:"Y-m-d" }}{% else %}None{% endif %}
97+
IESG Telechat date: {{ review_req.doc.telechat_date|default:'Not scheduled for a telechat' }}
98+
99+
Summary:
100+
101+
Major issues:
102+
103+
Minor issues:
104+
105+
Nits/editorial comments:
106+
107+
""")
108+
109+
class Migration(migrations.Migration):
110+
111+
dependencies = [
112+
('dbtemplate', '0002_auto_20180220_1052'),
113+
('doc','0011_reviewassignmentdocevent'),
114+
]
115+
116+
operations = [
117+
migrations.RunPython(forward, reverse)
118+
]

0 commit comments

Comments
 (0)