Skip to content

Commit a37bd90

Browse files
committed
Merged in [16926] from rjsparks@nostrum.com:
Flipped a sense to put the grace period on the right side of 'today' when sending review overdue reminders to team secretaries. Fixes ietf-tools#2816. - Legacy-Id: 16940 Note: SVN reference [16926] has been migrated to Git commit 7560e11
2 parents 63484a8 + 8f1e999 commit a37bd90

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

ietf/group/tests_review.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -565,13 +565,24 @@ def test_send_unavaibility_period_ending_reminder(self):
565565

566566
def test_send_review_reminder_overdue_assignment(self):
567567
today = datetime.date.today()
568+
569+
# An assignment that's exactly on the date at which the grace period expires
568570
review_req = ReviewRequestFactory(state_id='assigned', deadline=today - datetime.timedelta(5))
569571
reviewer = RoleFactory(name_id='reviewer', group=review_req.team,person__user__username='reviewer').person
570572
ReviewAssignmentFactory(review_request=review_req, state_id='assigned', assigned_on=review_req.time, reviewer=reviewer.email_set.first())
571573
secretary = RoleFactory(name_id='secr', group=review_req.team, person__user__username='reviewsecretary')
572574

575+
# A assignment that is not yet overdue
576+
not_overdue = today + datetime.timedelta(days=1)
577+
ReviewAssignmentFactory(review_request__team=review_req.team, review_request__state_id='assigned', review_request__deadline=not_overdue, state_id='assigned', assigned_on=not_overdue, reviewer=reviewer.email_set.first())
578+
579+
# An assignment that is overdue but is not past the grace period
580+
in_grace_period = today - datetime.timedelta(days=1)
581+
ReviewAssignmentFactory(review_request__team=review_req.team, review_request__state_id='assigned', review_request__deadline=in_grace_period, state_id='assigned', assigned_on=in_grace_period, reviewer=reviewer.email_set.first())
582+
573583
empty_outbox()
574584
log = send_review_reminder_overdue_assignment(today)
585+
self.assertEqual(len(log), 1)
575586

576587
self.assertEqual(len(outbox), 1)
577588
self.assertTrue(secretary.person.email_address() in outbox[0]["To"])

ietf/review/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -971,7 +971,7 @@ def send_unavaibility_period_ending_reminder(remind_date):
971971

972972
def send_review_reminder_overdue_assignment(remind_date):
973973
min_overdue_days = 5
974-
min_deadline = remind_date + datetime.timedelta(days=min_overdue_days)
974+
min_deadline = remind_date - datetime.timedelta(days=min_overdue_days)
975975
teams = Group.objects.exclude(reviewteamsettings=None)
976976
log = []
977977
for team in teams:

0 commit comments

Comments
 (0)