Make sure to strip possible mail header field values of whitespace before applying email.utils.unquite(). Resolution by kivinen@iki.fi, Fixes issue ietf-tools#2899.

levkowetz · levkowetz · commit 87bf4e8d5853 · 2020-03-21T17:34:37.000Z
- Legacy-Id: 17485
diff --git a/ietf/doc/views_review.py b/ietf/doc/views_review.py
@@ -860,7 +860,7 @@ def complete_review(request, name, assignment_id=None, acronym=None):
 
                 list_name = mailarch.list_name_from_email(assignment.review_request.team.list_email)
                 if list_name:
-                    review.external_url = mailarch.construct_message_url(list_name, email.utils.unquote(msg["Message-ID"]))
+                    review.external_url = mailarch.construct_message_url(list_name, email.utils.unquote(msg["Message-ID"].strip()))
                     review.save_with_history([close_event])
 
             if form.cleaned_data['email_ad'] or assignment.result in assignment.review_request.team.reviewteamsettings.notify_ad_when.all(): 
diff --git a/ietf/review/mailarch.py b/ietf/review/mailarch.py
@@ -97,8 +97,8 @@ def retrieve_messages_from_mbox(mbox_fileobj):
                 "splitfrom": email.utils.parseaddr(msg["From"]),
                 "subject": msg["Subject"],
                 "content": content.replace("\r\n", "\n").replace("\r", "\n").strip("\n"),
-                "message_id": email.utils.unquote(msg["Message-ID"]),
-                "url": email.utils.unquote(msg["Archived-At"]),
+                "message_id": email.utils.unquote(msg["Message-ID"].strip()),
+                "url": email.utils.unquote(msg["Archived-At"].strip()),
                 "date": msg["Date"],
                 "utcdate": (utcdate.date().isoformat(), utcdate.time().isoformat()) if utcdate else ("", ""),
             })
