new_resources = format_resources(doc.docextresource_set.all())

e = DocEvent(doc=doc, rev=doc.rev, by=request.user.person, type='changed_document')

e.desc = "Changed document external resources from:\n\n%s\n\nto:\n\n%s" % (old_resources, new_resources)

e.save()

doc.save_with_history([e])

from django.core.exceptions import ValidationError, ObjectDoesNotExist

from ietf.name.models import ReviewTypeName, ExtResourceName

from ietf.utils.validators import validate_external_resource_value

resources = forms.CharField(widget=forms.Textarea, label="Additional Resources", help_text="UPDATEME: Format: https://site/path (Optional description). Separate multiple entries with newline. Prefer HTTPS URLs where possible.", required=False)

if 'resources' in self.fields:

info = "Format: 'tag value (Optional description)'. " \

+ "Separate multiple entries with newline. When the value is a URL, use https:// where possible.<br>" \

+ "Valid tags: %s" % ', '.join([ o.slug for o in ExtResourceName.objects.all().order_by('slug') ])

self.fields['resources'].help_text = mark_safe('<div>'+info+'</div>')

def clean_resources(self):

lines = [x.strip() for x in self.cleaned_data["resources"].splitlines() if x.strip()]

errors = []

for l in lines:

parts = l.split()

if len(parts) == 1:

errors.append("Too few fields: Expected at least tag and value: '%s'" % l)

elif len(parts) >= 2:

name_slug = parts[0]

try:

name = ExtResourceName.objects.get(slug=name_slug)

except ObjectDoesNotExist:

errors.append("Bad tag in '%s': Expected one of %s" % (l, ', '.join([ o.slug for o in ExtResourceName.objects.all() ])))

continue

value = parts[1]

try:

validate_external_resource_value(name, value)

except ValidationError as e:

e.message += " : " + value

errors.append(e)

if errors:

raise ValidationError(errors)

return lines

def test_edit_extresources(self):

group = GroupFactory(acronym='mars',parent=GroupFactory(type_id='area'))

CharterFactory(group=group)

url = urlreverse('ietf.group.views.edit', kwargs=dict(group_type=group.type_id, acronym=group.acronym, action="edit", field="resources"))

login_testing_unauthorized(self, "secretary", url)

r = self.client.get(url)

self.assertEqual(r.status_code,200)

q = PyQuery(r.content)

self.assertEqual(len(q('form textarea[id=id_resources]')),1)

badlines = (

'github_repo https://github3.com/some/repo',

'github_notify badaddr',

'website /not/a/good/url'

'notavalidtag blahblahblah'

)

for line in badlines:

r = self.client.post(url, dict(resources=line, submit="1"))

self.assertEqual(r.status_code, 200)

q = PyQuery(r.content)

self.assertTrue(q('.alert-danger'))

goodlines = """

r = self.client.post(url, dict(resources=goodlines, submit="1"))

self.assertEqual(r.status_code,302)

group = Group.objects.get(acronym=group.acronym)

self.assertEqual(group.latest_event(GroupEvent,type="info_changed").desc[:20], 'Resources changed to')

self.assertIn('github_username githubuser', group.latest_event(GroupEvent,type="info_changed").desc)

self.assertEqual(group.groupextresource_set.count(), 4)

self.assertEqual(group.groupextresource_set.get(name__slug='github_repo').display_name, 'Some display text')

def format_resources(resources, fs="\n"):

res = []

for r in resources:

if r.display_name:

res.append("%s %s (%s)" % (r.name.slug, r.value, r.display_name.strip('()')))

else:

res.append("%s %s" % (r.name.slug, r.value))

# TODO: This is likely problematic if value has spaces. How then to delineate value and display_name? Perhaps in the short term move to comma or pipe separation.

# Might be better to shift to a formset instead of parsing these lines.

return fs.join(res)

if 'resources' in clean:

old_resources = sorted(format_resources(group.groupextresource_set.all()).splitlines())

new_resources = sorted(clean['resources'])

if old_resources != new_resources:

group.groupextresource_set.all().delete()

for u in new_resources:

parts = u.split(None, 2)

name = parts[0]

value = parts[1]

display_name = ' '.join(parts[2:]).strip('()')

group.groupextresource_set.create(value=value, name_id=name, display_name=display_name)

changes.append(('resources', new_resources, desc('Resources', ", ".join(new_resources), ", ".join(old_resources))))

resources=format_resources(group.groupextresource_set.all()),

{% with group.groupextresource_set.all as resources %}

{% if resources or can_edit_group %}

<tr>

<td></td>

<th>Additional Resources</th>

<td class="edit">

{% if can_edit_group %}

<a class="btn btn-default btn-xs" href="{% url 'ietf.group.views.edit' acronym=group.acronym field='resources' %}">Edit</a>

{% endif %}

</td>

<td>

{% if resources %}

<table class="col-md-12 col-sm-12 col-xs-12">

<tbody>

{% for resource in resources|dictsort:"display_name" %}

{% if resource.name.type.slug == 'url' or resource.name.type.slug == 'email' %}

<tr><td> - <a href="{{ resource.value }}" title="{{resource.name.name}}">{% firstof resource.display_name resource.name.name %}</a></td></tr>

{# Maybe make how a resource displays itself a method on the class so templates aren't doing this switching #}

{% else %}

<tr><td> - <span title="{{resource.name.name}}">{% firstof resource.display_name resource.name.name %}: {{resource.value}}</span></td></tr>

{% endif %}

{% endfor %}

</tbody>

</table>

{% endif %}

</td>

</tr>

{% endif %}

{% endwith %}