Changed the cache-filling code for doc.get_state() to avoid a period where the cache is seen as valid but empty. Addresses an issue where documents occasionally appear to be in an unexpected state.

levkowetz · levkowetz · commit 6d3699044617 · 2020-10-05T14:55:16.000Z
- Legacy-Id: 18564
diff --git a/ietf/doc/models.py b/ietf/doc/models.py
@@ -291,9 +291,10 @@ def get_state(self, state_type=None):
             state_type = self.type_id
 
         if not hasattr(self, "state_cache") or self.state_cache == None:
-            self.state_cache = {}
+            state_cache = {}
             for s in self.states.all():
-                self.state_cache[s.type_id] = s
+                state_cache[s.type_id] = s
+            self.state_cache = state_cache
 
         return self.state_cache.get(state_type, None)
 
