Add a test to check encrypted feedback

ejimenez · ejimenez · commit 5e3e4bfd2e2f · 2012-12-27T11:57:36.000Z
Ver ietf-tools#913 - Legacy-Id: 5157
diff --git a/ietf/nomcom/fields.py b/ietf/nomcom/fields.py
@@ -1,3 +1,5 @@
+import os
+
 import tempfile
 from django.conf import settings
 from django.db import models
@@ -15,13 +17,14 @@ def pre_save(self, instance, add):
             comments = getattr(instance, 'comments')
             position = getattr(instance, 'position')
             cert_file = position.nomcom.public_key.path
-            comments_file = tempfile.NamedTemporaryFile()
+            comments_file = tempfile.NamedTemporaryFile(delete=False)
             comments_file.write(comments)
+            comments_file.close()
 
             code, out, error = pipe("%s smime -encrypt -in %s %s" % (settings.OPENSSL_COMMAND,
                                     comments_file.name,
                                     cert_file))
-            comments_file.close()
+            os.unlink(comments_file.name)
             if not error:
                 instance.comments = out
                 return out
diff --git a/ietf/nomcom/tests.py b/ietf/nomcom/tests.py
@@ -1,13 +1,20 @@
+import os
+import tempfile
+
+from django.conf import settings
 from django.test import TestCase
 from django.db import IntegrityError
 from django.core.urlresolvers import reverse
+from django.core.files import File
 
 from ietf.utils.test_utils import login_testing_unauthorized
+from ietf.utils.pipe import pipe
 from ietf.nomcom.test_data import nomcom_test_data
-from ietf.nomcom.models import NomineePosition, Position, Nominee, NomineePositionState
+from ietf.nomcom.models import NomineePosition, Position, Nominee, \
+                               NomineePositionState, Feedback, FeedbackType
 
 
-class NomcomTest(TestCase):
+class NomcomViewsTest(TestCase):
     """Tests to create a new nomcom"""
     fixtures = ['names', 'nomcom_templates']
 
@@ -78,3 +85,90 @@ def test_nomine_position_unique(self):
         nominee_position = NomineePosition(position=position, nominee=self.nominee)
 
         self.assertRaises(IntegrityError, nominee_position.save)
+
+
+class FeedbackTest(TestCase):
+    fixtures = ['names', 'nomcom_templates']
+
+    def setUp(self):
+        nomcom_test_data()
+        self.generate_cert()
+
+    def generate_cert(self):
+        """Function to generate cert"""
+        config = """
+                [ req ]
+                distinguished_name = req_distinguished_name
+                string_mask        = utf8only
+                x509_extensions    = ss_v3_ca
+
+                [ req_distinguished_name ]
+                commonName           = Common Name (e.g., NomComYY)
+                commonName_default  = NomCom12
+
+                [ ss_v3_ca ]
+
+                subjectKeyIdentifier = hash
+                keyUsage = critical, digitalSignature, keyEncipherment, dataEncipherment
+                basicConstraints = critical, CA:true
+                subjectAltName = email:nomcom12@ietf.org
+                extendedKeyUsage= emailProtection"""
+
+        self.config_file = tempfile.NamedTemporaryFile(delete=False)
+        self.privatekey_file = tempfile.NamedTemporaryFile(delete=False)
+        self.cert_file = tempfile.NamedTemporaryFile(delete=False)
+
+        self.config_file.write(config)
+        self.config_file.close()
+
+        command = "%s req -config %s -x509 -new -newkey rsa:2048 -sha256 -days 730 -nodes \
+                   -keyout %s -out %s -batch"
+        code, out, error = pipe(command % (settings.OPENSSL_COMMAND,
+                                           self.config_file.name,
+                                           self.privatekey_file.name,
+                                           self.cert_file.name))
+        self.privatekey_file.close()
+        self.cert_file.close()
+
+    def test_encrypted_comments(self):
+
+        nominee = Nominee.objects.get(email__address="plain@example.com")
+        position = Position.objects.get(name='OAM')
+        nomcom = position.nomcom
+
+        # save the cert file in tmp
+        nomcom.public_key.storage.location = tempfile.gettempdir()
+        nomcom.public_key.save('cert', File(open(self.cert_file.name, 'r')))
+
+        comments = 'plain text'
+        feedback = Feedback.objects.create(position=position,
+                                            nominee=nominee,
+                                            comments=comments,
+                                            type=FeedbackType.objects.get(slug='nomina'))
+
+        # to check feedback comments are saved like enrypted data
+        self.assertNotEqual(feedback.comments, comments)
+
+        encrypted_file = tempfile.NamedTemporaryFile(delete=False)
+        encrypted_file.write(feedback.comments)
+        encrypted_file.close()
+
+        # to decrypt comments was encryped and check they are equal to the plain comments
+        decrypted_file = tempfile.NamedTemporaryFile(delete=False)
+        command = "%s smime -decrypt -in %s -out %s -inkey %s"
+        code, out, error = pipe(command % (settings.OPENSSL_COMMAND,
+                                           encrypted_file.name,
+                                           decrypted_file.name,
+                                           self.privatekey_file.name))
+
+        decrypted_file.close()
+        encrypted_file.close()
+
+        self.assertEqual(open(decrypted_file.name, 'r').read(), comments)
+
+        # delete tmps
+        os.unlink(self.config_file.name)
+        os.unlink(self.privatekey_file.name)
+        os.unlink(self.cert_file.name)
+        os.unlink(encrypted_file.name)
+        os.unlink(decrypted_file.name)
