Skip to content

Commit 51f24f0

Browse files
committed
Add edit public key and edit members views to private area.
See ietf-tools#904 ietf-tools#905 - Legacy-Id: 5315
1 parent 49ee366 commit 51f24f0

File tree

8 files changed

+49
-12
lines changed

8 files changed

+49
-12
lines changed

ietf/nomcom/forms.py

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
from django.conf import settings
22
from django import forms
3-
from django.contrib.formtools.preview import FormPreview
3+
from django.contrib.formtools.preview import FormPreview, AUTO_ID
44
from django.http import HttpResponseRedirect
55
from django.shortcuts import get_object_or_404
66
from django.core.urlresolvers import reverse
77
from django.template.loader import render_to_string
88
from django.utils.decorators import method_decorator
9+
from django.shortcuts import render_to_response
10+
from django.template.context import RequestContext
911

1012
from ietf.utils import unaccent
1113
from ietf.utils.mail import send_mail
@@ -79,6 +81,17 @@ def __call__(self, request, *args, **kwargs):
7981

8082
return super(EditMembersFormPreview, self).__call__(request, *args, **kwargs)
8183

84+
def preview_get(self, request):
85+
"Displays the form"
86+
f = self.form(auto_id=AUTO_ID)
87+
return render_to_response(self.form_template,
88+
{'form': f,
89+
'stage_field': self.unused_name('stage'),
90+
'state': self.state,
91+
'year': self.year,
92+
'selected': 'edit_members'},
93+
context_instance=RequestContext(request))
94+
8295
def parse_params(self, *args, **kwargs):
8396
members = self.group.role_set.filter(name__slug='member')
8497

ietf/nomcom/templatetags/__init__.py

Whitespace-only changes.
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
from django import template
2+
3+
from ietf.nomcom.utils import get_nomcom_by_year
4+
5+
register = template.Library()
6+
7+
8+
@register.filter
9+
def is_chair(user, year):
10+
if not user or not year:
11+
return False
12+
nomcom = get_nomcom_by_year(year=year)
13+
return nomcom.group.is_chair(user)

ietf/nomcom/test_data.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,10 @@ def nomcom_test_data():
113113
parent=None)
114114
# users
115115
for user in USERS:
116-
u, created = User.objects.get_or_create(username=user, password=user)
116+
u, created = User.objects.get_or_create(username=user)
117+
if created:
118+
u.set_password(user)
119+
u.save()
117120
person, created = Person.objects.get_or_create(
118121
name=user,
119122
ascii=user,

ietf/nomcom/views.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,9 @@ def edit_publickey(request, year):
146146
return render_to_response('nomcom/edit_publickey.html',
147147
{'form': form,
148148
'group': nomcom.group,
149-
'message': message}, RequestContext(request))
149+
'message': message,
150+
'year': year,
151+
'selected': 'edit_publickey'}, RequestContext(request))
150152

151153

152154
def ajax_position_text(request, position_id):

ietf/templates/nomcom/edit_members.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
{% extends "base.html" %}
1+
{% extends "nomcom/nomcom_private_base.html" %}
22

3-
{% block title %}Edit {{ state.group.acronym }} members{% endblock %}
3+
{% block subtitle %} - Edit members{% endblock %}
44

5-
{% block content %}
6-
<h1>Edit {{ state.group.acronym }} members</h1>
5+
{% block nomcom_content %}
6+
<h2>Edit members</h2>
77

88
{% if form.errors %}<div class="info-message-error">Please correct the following errors</div>{% endif %}
99

ietf/templates/nomcom/edit_publickey.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
{% extends "base.html" %}
1+
{% extends "nomcom/nomcom_private_base.html" %}
22

3-
{% block title %}Edit {{ group.acronym }} public key{% endblock %}
3+
{% block subtitle %}- Edit public key{% endblock %}
44

5-
{% block content %}
6-
<h1>Edit {{ group.acronym }} public key</h1>
5+
{% block nomcom_content %}
6+
<h2>Edit public key</h2>
77

88
{% if message %}
99
<div class="info-message-{{ message.0 }}">{{ message.1 }}</div>

ietf/templates/nomcom/nomcom_private_base.html

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,19 @@
11
{% extends "nomcom/nomcom_base.html" %}
22

3+
{% load nomcom_tags %}
4+
35
{% block content %}
46

57
<h1>Nomcom {{ year }} Private Area</h1>
68

79
<div class="ietf-navset">
810
{% if selected == "index" %}<span class="selected">List of nominees</span>{% else %}<a href="{% url nomcom_private_index year %}">List of nominees</a>{% endif %} |
9-
{% if selected == "merge" %}<span class="selected">Merge nominee email addr{% else %}<a href="{% url nomcom_private_merge year %}">Merge nominee email addr</a>{% endif %} |
1011
{% if selected == "nominate" %}<span class="selected">Nominate{% else %}<a href="{% url nomcom_private_nominate year %}">Nominate</a>{% endif %} |
12+
{% if user|is_chair:year %}
13+
{% if selected == "merge" %}<span class="selected">Merge nominee email addr{% else %}<a href="{% url nomcom_private_merge year %}">Merge nominee email addr</a>{% endif %} |
14+
{% if selected == "edit_members" %}<span class="selected">Edit nomcom members{% else %}<a href="{% url nomcom_edit_members year %}">Edit nomcom members</a>{% endif %} |
15+
{% if selected == "edit_publickey" %}<span class="selected">Edit public key{% else %}<a href="{% url nomcom_edit_publickey year %}">Edit public key</a>{% endif %}
16+
{% endif %}
1117
</div>
1218

1319

0 commit comments

Comments
 (0)