Skip to content

Commit 4f1dcd6

Browse files
authored
fix: Don't make a <tbody> for each row (ietf-tools#3808)
Fixes ietf-tools#3805.
1 parent c14a303 commit 4f1dcd6

File tree

1 file changed

+13
-22
lines changed

1 file changed

+13
-22
lines changed

ietf/templates/stats/review_stats.html

Lines changed: 13 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -174,11 +174,8 @@ <h2>Completion status and completion time</h2>
174174
</tr>
175175
</thead>
176176
{% for row in data %}
177-
{% if forloop.revcounter != 1 %}<tbody>{% endif %}
178-
{% if forloop.last %}
179-
{% if forloop.revcounter != 1 %}</tbody>{% endif %}
180-
<tfoot>
181-
{% endif %}
177+
{% if forloop.first %}<tbody>{% endif %}
178+
{% if forloop.last %}</tbody><tfoot>{% endif %}
182179
<tr>
183180
<td>{{ row.obj }}</td>
184181
<td>{{ row.open_in_time }}</td>
@@ -196,8 +193,8 @@ <h2>Completion status and completion time</h2>
196193
{% endif %}
197194
</td>
198195
</tr>
199-
{% endfor %}
200-
</tfoot>
196+
{% if forloop.last %}</tfoot>{% endif %}
197+
{% endfor %}
201198
</table>
202199
{% elif stats_type == "results" %}
203200
<h2>
@@ -221,11 +218,8 @@ <h2>
221218
</tr>
222219
</thead>
223220
{% for row in data %}
224-
{% if forloop.revcounter != 1 %}<tbody>{% endif %}
225-
{% if forloop.last %}
226-
{% if forloop.revcounter != 1 %}</tbody>{% endif %}
227-
<tfoot>
228-
{% endif %}
221+
{% if forloop.first %}<tbody>{% endif %}
222+
{% if forloop.last %}</tbody><tfoot>{% endif %}
229223
<tr>
230224
<td>
231225
{{ row.obj }}
@@ -236,8 +230,8 @@ <h2>
236230
</td>
237231
{% endfor %}
238232
</tr>
239-
{% endfor %}
240-
</tfoot>
233+
{% if forloop.last %}</tfoot>{% endif %}
234+
{% endfor %}
241235
</table>
242236
{% elif stats_type == "states" %}
243237
<h2>
@@ -261,11 +255,8 @@ <h2>
261255
</tr>
262256
</thead>
263257
{% for row in data %}
264-
{% if forloop.revcounter != 1 %}<tbody>{% endif %}
265-
{% if forloop.last %}
266-
{% if forloop.revcounter != 1 %}</tbody>{% endif %}
267-
<tfoot>
268-
{% endif %}
258+
{% if forloop.first %}<tbody>{% endif %}
259+
{% if forloop.last %}</tbody><tfoot>{% endif %}
269260
<tr>
270261
<td>
271262
{{ row.obj }}
@@ -276,8 +267,8 @@ <h2>
276267
</td>
277268
{% endfor %}
278269
</tr>
279-
{% endfor %}
280-
</tfoot>
270+
{% if forloop.last %}</tfoot>{% endif %}
271+
{% endfor %}
281272
</table>
282273
{% elif stats_type == "time" and selected_teams %}
283274
<h2>
@@ -347,4 +338,4 @@ <h2>
347338
<script src="{% static 'ietf/js/review-stats.js' %}">
348339
</script>
349340
{% endif %}
350-
{% endblock %}
341+
{% endblock %}

0 commit comments

Comments
 (0)