Skip to content

Commit 2c2effd

Browse files
committed
Added a form clean() for the reminder dates of the nomcom edit form, to make something appropriate out of edits that remove reminder dates, rather than clicking 'delete'. This fixes a potential exception, when a blank date cannot be saved, and also does what the user expected (deletes a blanked date).
- Legacy-Id: 15521
1 parent 08df854 commit 2c2effd

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

ietf/nomcom/forms.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -661,6 +661,14 @@ def __init__(self, *args, **kwargs):
661661
super(ReminderDatesForm, self).__init__(*args, **kwargs)
662662
self.fields['date'].required = False
663663

664+
def clean(self):
665+
cleaned_data = super(ReminderDatesForm, self).clean()
666+
date = cleaned_data.get('date')
667+
delete = cleaned_data.get('DELETE')
668+
if date is None:
669+
cleaned_data['date'] = ''
670+
cleaned_data['DELETE'] = True
671+
return cleaned_data
664672

665673
class MutableFeedbackForm(forms.ModelForm):
666674

0 commit comments

Comments
 (0)