Include information about previous team reviews in assignement emails. Fixes ietf-tools#2392. Commit ready for merge.

rjsparks · rjsparks · commit 0a9737a5d2e8 · 2017-12-26T22:13:13.000Z
- Legacy-Id: 14466
diff --git a/ietf/doc/tests_review.py b/ietf/doc/tests_review.py
@@ -276,6 +276,7 @@ def test_assign_reviewer(self):
             type=ReviewTypeName.objects.get(slug="early"),
             team=review_req.team,
             state=ReviewRequestStateName.objects.get(slug="completed"),
+            result_id='serious-issues',
             reviewed_rev="01",
             deadline=datetime.date.today() - datetime.timedelta(days=80),
             reviewer=reviewer_email,
diff --git a/ietf/review/utils.py b/ietf/review/utils.py
@@ -451,10 +451,26 @@ def assign_review_request_to_reviewer(request, review_req, reviewer, add_skip=Fa
         state=None,
     )
 
+    msg = "%s has assigned you as a reviewer for this document." % request.user.person.ascii
+    prev_team_reviews = ReviewRequest.objects.filter(
+        doc=review_req.doc,
+        state="completed",
+        team=review_req.team,
+    )
+    if prev_team_reviews.exists():
+        msg = msg + '\n\nThis team has completed other reviews of this document:\n'
+        for req in prev_team_reviews:
+            msg += u'%s %s -%s %s\n'% (
+                     req.review_done_time().strftime('%d %b %Y'), 
+                     req.reviewer.person.ascii,
+                     req.reviewed_rev or req.requested_rev,
+                     req.result.name,
+                   )
+
     email_review_request_change(
         request, review_req,
         "%s %s assignment: %s" % (review_req.team.acronym.capitalize(), review_req.type.name,review_req.doc.name),
-        "%s has assigned you as a reviewer for this document." % request.user.person,
+        msg ,
         by=request.user.person, notify_secretary=False, notify_reviewer=True, notify_requested_by=False)
 
 def possibly_advance_next_reviewer_for_team(team, assigned_review_to_person_id, add_skip=False):
