Add proper handling for SIGKILL'ed shim

mlaventure · mlaventure · commit fe5f3d558120 · 2016-09-07T10:30:02.000-07:00
Signed-off-by: Kenfe-Mickael Laventure &lt;mickael.laventure@gmail.com&gt;
diff --git a/containerd/main.go b/containerd/main.go
@@ -21,6 +21,7 @@ import (
 	"github.com/docker/containerd/api/grpc/server"
 	"github.com/docker/containerd/api/grpc/types"
 	"github.com/docker/containerd/api/http/pprof"
+	"github.com/docker/containerd/osutils"
 	"github.com/docker/containerd/supervisor"
 	"github.com/docker/docker/pkg/listeners"
 	"github.com/rcrowley/go-metrics"
@@ -157,6 +158,7 @@ func main() {
 func daemon(context *cli.Context) error {
 	s := make(chan os.Signal, 2048)
 	signal.Notify(s, syscall.SIGTERM, syscall.SIGINT)
+	osutils.SetSubreaper(1)
 	sv, err := supervisor.New(
 		context.String("state-dir"),
 		context.String("runtime"),
diff --git a/integration-test/start_test.go b/integration-test/start_test.go
@@ -3,6 +3,7 @@ package main
 import (
 	"fmt"
 	"os"
+	"os/exec"
 	"path/filepath"
 	"syscall"
 	"time"
@@ -488,3 +489,50 @@ func swapEnabled() bool {
 	_, err := os.Stat("/sys/fs/cgroup/memory/memory.memsw.limit_in_bytes")
 	return err == nil
 }
+
+func (cs *ContainerdSuite) TestSigkillShimReuseName(t *check.C) {
+	bundleName := "busybox-top"
+	if err := CreateBusyboxBundle(bundleName, []string{"top"}); err != nil {
+		t.Fatal(err)
+	}
+	containerID := "top"
+	c, err := cs.StartContainer(containerID, bundleName)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	// Sigkill the shim
+	exec.Command("pkill", "-9", "containerd-shim").Run()
+
+	// Wait for it to be reaped
+	for _, evt := range []types.Event{
+		{
+			Type:   "start-container",
+			Id:     containerID,
+			Status: 0,
+			Pid:    "",
+		},
+		{
+			Type:   "exit",
+			Id:     containerID,
+			Status: 128 + 9,
+			Pid:    "init",
+		},
+	} {
+		ch := c.GetEventsChannel()
+		select {
+		case e := <-ch:
+			evt.Timestamp = e.Timestamp
+
+			t.Assert(*e, checker.Equals, evt)
+		case <-time.After(2 * time.Second):
+			t.Fatal("Container took more than 2 seconds to terminate")
+		}
+	}
+
+	// Start a new continer with the same name
+	c, err = cs.StartContainer(containerID, bundleName)
+	if err != nil {
+		t.Fatal(err)
+	}
+}
diff --git a/runtime/container.go b/runtime/container.go
@@ -253,6 +253,8 @@ func (c *container) Delete() error {
 	args = append(args, "delete", c.id)
 	if b, derr := exec.Command(c.runtime, args...).CombinedOutput(); err != nil {
 		err = fmt.Errorf("%s: %q", derr, string(b))
+	} else if len(b) > 0 {
+		logrus.Debugf("%v %v: %q", c.runtime, args, string(b))
 	}
 	return err
 }
diff --git a/runtime/process.go b/runtime/process.go
@@ -12,6 +12,7 @@ import (
 	"sync"
 	"syscall"
 
+	"github.com/Sirupsen/logrus"
 	"github.com/docker/containerd/specs"
 	"golang.org/x/sys/unix"
 )
@@ -193,8 +194,58 @@ func (p *process) Resize(w, h int) error {
 	return err
 }
 
-func (p *process) ExitStatus() (int, error) {
+func (p *process) handleSigkilledShim(rst int, rerr error) (int, error) {
+	if rerr == nil || p.cmd == nil || p.cmd.Process == nil {
+		return rst, rerr
+	}
+
+	// Possible that the shim was SIGKILLED
+	e := unix.Kill(p.cmd.Process.Pid, 0)
+	if e != syscall.ESRCH {
+		return rst, rerr
+	}
+
+	// Ensure we got the shim ProcessState
+	<-p.cmdDoneCh
+
+	shimStatus := p.cmd.ProcessState.Sys().(syscall.WaitStatus)
+	if shimStatus.Signaled() && shimStatus.Signal() == syscall.SIGKILL {
+		logrus.Debugf("containerd: ExitStatus(container: %s, process: %s): shim was SIGKILL'ed reaping its child with pid %d", p.container.id, p.id, p.pid)
+
+		var (
+			status unix.WaitStatus
+			rusage unix.Rusage
+			wpid   int
+		)
+
+		for wpid == 0 {
+			wpid, e = unix.Wait4(p.pid, &status, unix.WNOHANG, &rusage)
+			if e != nil {
+				logrus.Debugf("containerd: ExitStatus(container: %s, process: %s): Wait4(%d): %v", p.container.id, p.id, p.pid, rerr)
+				return rst, rerr
+			}
+		}
+
+		if wpid == p.pid {
+			rerr = nil
+			rst = 128 + int(shimStatus.Signal())
+		} else {
+			logrus.Errorf("containerd: ExitStatus(container: %s, process: %s): unexpected returned pid from wait4 %v (expected %v)", p.container.id, p.id, wpid, p.pid)
+		}
+
+		p.stateLock.Lock()
+		p.state = Stopped
+		p.stateLock.Unlock()
+	}
+
+	return rst, rerr
+}
+
+func (p *process) ExitStatus() (rst int, rerr error) {
 	data, err := ioutil.ReadFile(filepath.Join(p.root, ExitStatusFile))
+	defer func() {
+		rst, rerr = p.handleSigkilledShim(rst, rerr)
+	}()
 	if err != nil {
 		if os.IsNotExist(err) {
 			return -1, ErrProcessNotExited

Original file line number	Diff line number	Diff line change
`@@ -253,6 +253,8 @@ func (c *container) Delete() error {`
`253`	`253`	`args = append(args, "delete", c.id)`
`254`	`254`	`if b, derr := exec.Command(c.runtime, args...).CombinedOutput(); err != nil {`
`255`	`255`	`err = fmt.Errorf("%s: %q", derr, string(b))`
	`256`	`+ } else if len(b) > 0 {`
	`257`	`+ logrus.Debugf("%v %v: %q", c.runtime, args, string(b))`
`256`	`258`	`}`
`257`	`259`	`return err`
`258`	`260`	`}`