Use named error return for service#StartShim

tedyu · tedyu · commit f8ade8debd88 · 2020-02-27T06:18:05.000-08:00
Signed-off-by: Ted Yu &lt;yuzhihong@gmail.com&gt;
diff --git a/runtime/v2/runc/v2/service.go b/runtime/v2/runc/v2/service.go
@@ -159,7 +159,7 @@ func readSpec() (*spec, error) {
 	return &s, nil
 }
 
-func (s *service) StartShim(ctx context.Context, id, containerdBinary, containerdAddress, containerdTTRPCAddress string) (string, error) {
+func (s *service) StartShim(ctx context.Context, id, containerdBinary, containerdAddress, containerdTTRPCAddress string) (_ string, retErr error) {
 	cmd, err := newCommand(ctx, id, containerdBinary, containerdAddress, containerdTTRPCAddress)
 	if err != nil {
 		return "", err
@@ -202,7 +202,7 @@ func (s *service) StartShim(ctx context.Context, id, containerdBinary, container
 		return "", err
 	}
 	defer func() {
-		if err != nil {
+		if retErr != nil {
 			cmd.Process.Kill()
 		}
 	}()

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ func readSpec() (*spec, error) {`
`159`	`159`	`return &s, nil`
`160`	`160`	`}`
`161`	`161`
`162`		`-func (s *service) StartShim(ctx context.Context, id, containerdBinary, containerdAddress, containerdTTRPCAddress string) (string, error) {`
	`162`	`+func (s *service) StartShim(ctx context.Context, id, containerdBinary, containerdAddress, containerdTTRPCAddress string) (_ string, retErr error) {`
`163`	`163`	`cmd, err := newCommand(ctx, id, containerdBinary, containerdAddress, containerdTTRPCAddress)`
`164`	`164`	`if err != nil {`
`165`	`165`	`return "", err`
`@@ -202,7 +202,7 @@ func (s *service) StartShim(ctx context.Context, id, containerdBinary, container`
`202`	`202`	`return "", err`
`203`	`203`	`}`
`204`	`204`	`defer func() {`
`205`		`- if err != nil {`
	`205`	`+ if retErr != nil {`
`206`	`206`	`cmd.Process.Kill()`
`207`	`207`	`}`
`208`	`208`	`}()`